Visitar URL original
Rollback package dependency versions for analyzers by AArnott · Pull Request #1641 · MessagePack-CSharp/MessagePack-CSharp · GitHub
Skip to content

Rollback package dependency versions for analyzers #1641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AArnott merged 2 commits into from
Jun 12, 2023
Merged

Rollback package dependency versions for analyzers #1641

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c68c8c
Retarget net461 to net462
AArnott Jun 12, 2023
d62699e
Rollback package dependency versions for analyzers
AArnott Jun 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

<!-- https://learn.microsoft.com/en-us/visualstudio/extensibility/roslyn-version-support?view=vs-2022 -->
<MicrosoftCodeAnalysisVersion>4.3.0</MicrosoftCodeAnalysisVersion>
<MicrosoftCodeAnalysisVersion Condition="'$(IsTestProject)'=='true'">4.3.0</MicrosoftCodeAnalysisVersion>
<MicrosoftCodeAnalysisVersion Condition="'$(IsAnalyzerProject)'!='true'">4.3.0</MicrosoftCodeAnalysisVersion>
<MicrosoftCodeAnalysisTestingVersion>1.1.2-beta1.23163.2</MicrosoftCodeAnalysisTestingVersion>

<!-- Unity 2021.3 has Roslyn 3.8.0 (https://docs.unity3d.com/Manual/roslyn-analyzers.html) -->
Expand All @@ -26,7 +26,7 @@
<PackageVersion Include="Jil" version="2.17.0" />
<PackageVersion Include="MessagePack" Version="2.1.90" />
<PackageVersion Include="Microsoft.AspNetCore.Mvc.Core" Version="2.2.5" />
<PackageVersion Include="Microsoft.Bcl.AsyncInterfaces" Version="6.0.0" />
<PackageVersion Include="Microsoft.Bcl.AsyncInterfaces" Version="7.0.0" />
<PackageVersion Include="Microsoft.Build.Framework" Version="16.5.0" ExcludeAssets="runtime" />
<PackageVersion Include="Microsoft.Build.Locator" Version="1.5.5" />
<PackageVersion Include="Microsoft.Build.Utilities.Core" Version="16.5.0" />
Expand Down Expand Up @@ -74,7 +74,16 @@
<PackageVersion Include="xunit" Version="2.4.2" />
<PackageVersion Include="ZeroFormatter" Version="1.6.4" />
</ItemGroup>
<ItemGroup Condition="'$(IsAnalyzerProject)'=='true'">
<PackageVersion Update="Microsoft.Bcl.AsyncInterfaces" Version="6.0.0" />
<PackageVersion Update="System.Collections.Immutable" Version="6.0.0" />
<PackageVersion Update="System.Memory" Version="4.5.4" />
<PackageVersion Update="System.Reflection.Metadata" Version="6.0.0" />
<PackageVersion Update="System.Runtime.CompilerServices.Unsafe" Version="6.0.0" />
<PackageVersion Update="System.Text.Json" Version="6.0.0" />
</ItemGroup>
<ItemGroup Condition="'$(MicrosoftCodeAnalysisVersion)'=='$(CodeAnalysisVersionForUnity)'">
<!-- These versions carefully chosen to support Unity. -->
<PackageVersion Update="System.CodeDom" Version="5.0.0" />
<PackageVersion Update="System.Collections.Immutable" Version="5.0.0" />
<PackageVersion Update="System.Text.Json" Version="5.0.0" />
Expand Down
2 changes: 1 addition & 1 deletion sandbox/PerfNetFramework/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ When collecting ETL traces, use these settings in the Collect->Run dialog:

| Setting | Value |
|-------------|-------|
| Command | `dotnet run -c release -p .\sandbox\PerfNetFramework\ -f net461 --no-build`
| Command | `dotnet run -c release -p .\sandbox\PerfNetFramework\ -f net472 --no-build`
| Current Dir | `d:\git\messagepack-csharp` (or wherever your enlistment is)
| Additional Providers | `*MessagePack-Benchmark`
| No V3.X NGen | Checked
Expand Down
2 changes: 1 addition & 1 deletion sandbox/TestData.InvalidProject/TestData.InvalidProject.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFramework>net461</TargetFramework>
<TargetFramework>net462</TargetFramework>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="MessagePack" />
Expand Down
2 changes: 1 addition & 1 deletion sandbox/TestData.InvalidSyntax/TestData.InvalidSyntax.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFramework>net461</TargetFramework>
<TargetFramework>net462</TargetFramework>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="MessagePack" />
Expand Down
2 changes: 1 addition & 1 deletion sandbox/TestData2/TestData2.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFramework>net461</TargetFramework>
<TargetFramework>net462</TargetFramework>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="MessagePack" />
Expand Down
1 change: 1 addition & 0 deletions src/Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
<Nullable>enable</Nullable>
<SignAssembly>True</SignAssembly>
<AssemblyOriginatorKeyFile>$(MSBuildThisFileDirectory)..\opensource.snk</AssemblyOriginatorKeyFile>
<EnforceExtendedAnalyzerRules Condition="'$(IsAnalyzerProject)'=='true'">true</EnforceExtendedAnalyzerRules>
</PropertyGroup>
<Import Project="$([MSBuild]::GetPathOfFileAbove($(MSBuildThisFile), $(MSBuildThisFileDirectory)..))" />
</Project>
6 changes: 6 additions & 0 deletions src/MessagePack.Analyzers.CodeFixes/Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
<Project>
<PropertyGroup>
<IsAnalyzerProject>true</IsAnalyzerProject>
</PropertyGroup>
<Import Project="$([MSBuild]::GetPathOfFileAbove($(MSBuildThisFile), $(MSBuildThisFileDirectory)..))" />
</Project>
6 changes: 6 additions & 0 deletions src/MessagePack.Analyzers/Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
<Project>
<PropertyGroup>
<IsAnalyzerProject>true</IsAnalyzerProject>
</PropertyGroup>
<Import Project="$([MSBuild]::GetPathOfFileAbove($(MSBuildThisFile), $(MSBuildThisFileDirectory)..))" />
</Project>
6 changes: 6 additions & 0 deletions src/MessagePack.SourceGenerator.Unity/Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
<Project>
<PropertyGroup>
<IsAnalyzerProject>true</IsAnalyzerProject>
</PropertyGroup>
<Import Project="$([MSBuild]::GetPathOfFileAbove($(MSBuildThisFile), $(MSBuildThisFileDirectory)..))" />
</Project>
6 changes: 6 additions & 0 deletions src/MessagePack.SourceGenerator/Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
<Project>
<PropertyGroup>
<IsAnalyzerProject>true</IsAnalyzerProject>
</PropertyGroup>
<Import Project="$([MSBuild]::GetPathOfFileAbove($(MSBuildThisFile), $(MSBuildThisFileDirectory)..))" />
</Project>