Visitar URL original
feat: add by-ref struct formatter dispatch and codefix stability by vrecluse · Pull Request #2251 · MessagePack-CSharp/MessagePack-CSharp · GitHub
Skip to content

feat: add by-ref struct formatter dispatch and codefix stability - #2251

Open
vrecluse wants to merge 16 commits into
MessagePack-CSharp:masterfrom
vrecluse:feature/struct-byref-formatter
Open

vrecluse wants to merge 16 commits into
MessagePack-CSharp:masterfrom
vrecluse:feature/struct-byref-formatter

Conversation

@vrecluse

Copy link
Copy Markdown

Summary

  • add by-ref serializer/formatter dispatch for struct types with compatibility fallback to by-value interfaces
  • route DynamicObjectResolver and source-generated member serialization through by-ref dispatch, with nullable struct fallback fix
  • stabilize analyzer codefix output by preserving original line endings and fixing modifier trivia handling
  • remove temporary design/plan docs from this branch before PR

Test Plan

  • dotnet test tests/MessagePack.SourceGenerator.Tests/MessagePack.SourceGenerator.Tests.csproj -v minimal
  • dotnet test MessagePack.sln -v minimal

@vrecluse

Copy link
Copy Markdown
Author

Adding context links for reviewers:

This PR continues that direction with by-ref dispatch for struct formatters while preserving compatibility with existing by-value formatters, and includes follow-up fixes found during full-solution regression (nullable struct dispatch in dynamic resolver, DateTimeOffset deserialization, and codefix line-ending stability).

@vrecluse

Copy link
Copy Markdown
Author

@dotnet-policy-service agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant