Visitar URL original
CCM-20515: switched client-provided URI placeholders to use curly brackets by cgitim · Pull Request #1087 · NHSDigital/communications-manager-api · GitHub
Skip to content

CCM-20515: switched client-provided URI placeholders to use curly brackets - #1087

Merged
cgitim merged 6 commits into
releasefrom
feature/CCM-20515-bracket-fix
Jul 21, 2026
Merged

CCM-20515: switched client-provided URI placeholders to use curly brackets#1087
cgitim merged 6 commits into
releasefrom
feature/CCM-20515-bracket-fix

Conversation

@cgitim

@cgitim cgitim commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

Summary

The use of angle brackets (< and >) in placeholders for client-provided callback endpoint URIs has caused problems with the pages for those endpoints and links to them which are embedded in markdown.

Reviews Required

  • Dev
  • Test
  • Tech Author
  • Product Owner

Checklist

  • Brief description of work completed, and any technical decisions made as part of the PR
  • PR link added as a comment to the relevant JIRA ticket
  • PR link shared on Slack and/or Teams
  • 2 reviews received
  • Tester approval

@github-actions

github-actions Bot commented Jul 17, 2026

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

CCM-20515

@github-actions

github-actions Bot commented Jul 17, 2026

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

CCM-20515

Ian-Hodges
Ian-Hodges reviewed Jul 20, 2026
View reviewed changes
Comment thread specification/documentation/APIDescription.md Resolved
Ian-Hodges
Ian-Hodges reviewed Jul 20, 2026
View reviewed changes
Comment thread scripts/publish_zap_compatible.py Resolved
@github-actions

github-actions Bot commented Jul 20, 2026

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

CCM-20515

@cgitim @Ian-Hodges
replace {} in links (Bloomreach adds them)
b0ca945 
Co-authored-by: Ian Hodges <ian.hodges1@nhs.net>
@github-actions

github-actions Bot commented Jul 20, 2026

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

CCM-20515

@github-actions

github-actions Bot commented Jul 20, 2026

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

CCM-20515

@github-actions

github-actions Bot commented Jul 20, 2026

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

CCM-20515

Ian-Hodges
Ian-Hodges approved these changes Jul 21, 2026
View reviewed changes

@Ian-Hodges Ian-Hodges left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the published spec in Bloomreach and the link is working.

@cgitim
cgitim merged commit 7d5b4ba into release Jul 21, 2026
6 checks passed
@cgitim
cgitim deleted the feature/CCM-20515-bracket-fix branch July 21, 2026 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ian-Hodges Ian-Hodges Ian-Hodges approved these changes
@mark-r-bjss mark-r-bjss mark-r-bjss approved these changes
+1 more reviewer
@mjewildnhs mjewildnhs mjewildnhs approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cgitim @Ian-Hodges @mark-r-bjss @mjewildnhs