Replacing ProcessInfoLayoutRenderer with ProcessStartLayoutRenderer - #6231

tests/NLog.UnitTests/LayoutRenderers/ProcessStartLayoutRendererTests.cs (1)

41-48: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Add test coverage for custom Format and IRawValue.

The single test covers the UTC path but misses:

• Custom Format (e.g., ${processstart:yyyy-MM-dd}) to verify [DefaultParameter] wiring.
• IRawValue.TryGetRawValue to verify the raw DateTime is returned correctly for structured logging.
• Default UniversalTime=false (local time) — can be tested by computing expected from LogEventInfo.ZeroDate.ToLocalTime().

♻️ Suggested additional tests

         [Fact]
         public void RenderProcessStartLayoutRenderer()
         {
             Layout layout = "${processstart:Culture=InvariantCulture:UniversalTime=true}";
             var timestamp = LogEventInfo.ZeroDate;
             var expected = timestamp.ToString("yyyy-MM-dd HH:mm:ss", System.Globalization.CultureInfo.InvariantCulture);
             AssertLayoutRendererOutput(layout, LogEventInfo.CreateNullEvent(), expected);
         }
+
+        [Fact]
+        public void RenderProcessStartCustomFormatTest()
+        {
+            Layout layout = "${processstart:format=yyyy-MM-dd:Culture=InvariantCulture:UniversalTime=true}";
+            var expected = LogEventInfo.ZeroDate.ToString("yyyy-MM-dd", System.Globalization.CultureInfo.InvariantCulture);
+            AssertLayoutRendererOutput(layout, LogEventInfo.CreateNullEvent(), expected);
+        }
+
+        [Fact]
+        public void RenderProcessStartLocalTimeTest()
+        {
+            Layout layout = "${processstart:Culture=InvariantCulture}";
+            var expected = LogEventInfo.ZeroDate.ToLocalTime().ToString("yyyy-MM-dd HH:mm:ss", System.Globalization.CultureInfo.InvariantCulture);
+            AssertLayoutRendererOutput(layout, LogEventInfo.CreateNullEvent(), expected);
+        }

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@tests/NLog.UnitTests/LayoutRenderers/ProcessStartLayoutRendererTests.cs`
around lines 41 - 48, Add test coverage alongside
RenderProcessStartLayoutRenderer for the custom Format parameter (for example,
yyyy-MM-dd), IRawValue.TryGetRawValue returning the underlying DateTime, and the
default UniversalTime=false behavior using LogEventInfo.ZeroDate.ToLocalTime().

tests/NLog.UnitTests/LayoutRenderers/ProcessInfoLayoutRendererTests.cs (1)

44-55: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Consider strengthening assertions beyond Assert.NotEmpty.

The test verifies that every property produces non-empty output, which is a useful smoke test. However, it doesn't validate correctness of any specific value (e.g., StartTime producing a valid date, Id matching the current process ID). Adding targeted assertions for key properties like Id, StartTime, and StartTimeUtc would increase confidence in the refactored implementation.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@tests/NLog.UnitTests/LayoutRenderers/ProcessInfoLayoutRendererTests.cs`
around lines 44 - 55, Strengthen ProcessInfoPropertyTest with targeted
assertions for key properties instead of relying only on Assert.NotEmpty: verify
Id matches the current process ID and assert StartTime and StartTimeUtc render
parseable, valid date-time values. Keep the existing loop as a smoke test for
the remaining ProcessInfoProperty values.

src/NLog/LayoutRenderers/ProcessInfoLayoutRenderer.cs (1)

137-139: 🎯 Functional Correctness | 🔵 Trivial | 💤 Low value

MachineName now renders empty — consider Environment.MachineName.

This branch emits an empty string (the test even skips MachineName for this reason), a behavior change from the previous real value. Environment.MachineName is AOT-safe and would preserve the prior output.

♻️ Proposed change

                 case ProcessInfoProperty.MachineName:
-                    builder.Append("");
+                    builder.Append(Environment.MachineName);
                     break;

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/NLog/LayoutRenderers/ProcessInfoLayoutRenderer.cs` around lines 137 -
139, Update the ProcessInfoProperty.MachineName branch in
ProcessInfoLayoutRenderer to append Environment.MachineName instead of an empty
string, preserving the prior real machine-name output and allowing the
corresponding test to cover this property.