Visitar URL original
NLog.Schema - NLog.Targets.HttpClient + NLog.Targets.OpenTelemetryHttp by snakefoot · Pull Request #6255 · NLog/NLog · GitHub
Skip to content

NLog.Schema - NLog.Targets.HttpClient + NLog.Targets.OpenTelemetryHttp - #6255

Merged
snakefoot merged 1 commit into
NLog:devfrom
snakefoot:NLog62_Schema
Aug 20, 2026
Merged

NLog.Schema - NLog.Targets.HttpClient + NLog.Targets.OpenTelemetryHttp#6255
snakefoot merged 1 commit into
NLog:devfrom
snakefoot:NLog62_Schema

Conversation

@snakefoot

@snakefoot snakefoot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@coderabbitai

coderabbitai Bot commented Aug 20, 2026 •
edited
Loading

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: c647e92a-d20a-4405-b53d-5e3f4f915691

📥 Commits

Reviewing files that changed from the base of the PR and between 6d5e3b4 and 2c3570b.

📒 Files selected for processing (1)
  • tools/MakeNLogXSD/XsdFileGenerator.cs

Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review.

Walkthrough

The changes add two target package references and map ActivitySpanId and ActivityTraceId to xs:string in the XSD generator.

Changes

NLog tooling updates

Layer / File(s) Summary
Add target package references
tools/NLogNugetPackages/NLogNugetPackages.csproj		 Adds NLog.Targets.HttpClient and NLog.Targets.OpenTelemetryHttp at version 6.*.
Map diagnostic activity types
tools/MakeNLogXSD/XsdFileGenerator.cs		 Maps ActivitySpanId and ActivityTraceId to xs:string.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 2c357

This localized documentation/schema tooling update introduces no actionable merge-blocking risk; it is merge-ready after normal checks and review.

Poem

I’m a rabbit checking the trail,
Two target packages join the mail.
Activity types become strings,
The XSD generator gains new wings.
Hop, build, and validate!

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ❓ Inconclusive No pull request description was provided, so the change intent is not documented beyond the title. Add a brief description of the package references and the XSD type mappings.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the two packages added by the pull request and matches the main changeset.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

sonarqubecloud Bot commented Aug 20, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@snakefoot
snakefoot merged commit b100993 into NLog:dev Aug 20, 2026
6 checks passed
@snakefoot snakefoot added this to the 6.2.1 milestone Sep 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

documentation size/XS

Projects

None yet

Milestone

6.2.1

Development

Successfully merging this pull request may close these issues.

1 participant

@snakefoot