Visitar URL original
Layout - FromLiteral is IsInitialized from the start and ThreadAgnostic by snakefoot · Pull Request #6280 · NLog/NLog · GitHub
Skip to content

Layout - FromLiteral is IsInitialized from the start and ThreadAgnostic - #6280

Merged
snakefoot merged 1 commit into
NLog:devfrom
snakefoot:Layout_Literal_Init
Sep 13, 2026
Merged

Layout - FromLiteral is IsInitialized from the start and ThreadAgnostic#6280
snakefoot merged 1 commit into
NLog:devfrom
snakefoot:Layout_Literal_Init

Conversation

@snakefoot

@snakefoot snakefoot commented Sep 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

More generalized version of #6279

@snakefoot snakefoot added this to the 6.2.1 milestone Sep 13, 2026
@coderabbitai

coderabbitai Bot commented Sep 13, 2026 •
edited
Loading

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Advanced

Run ID: d510b016-0bc6-4c64-ba58-72b0391de97c

📥 Commits

Reviewing files that changed from the base of the PR and between 1bd0842 and 6ece3ea.

📒 Files selected for processing (2)
  • src/NLog/Layouts/Layout.cs
  • src/NLog/Layouts/SimpleLayout.cs

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.

Walkthrough

The change updates initialization behavior for Layout.Empty and fixed-text SimpleLayout instances. Fixed-text layouts now mark themselves initialized and thread-agnostic.

Changes

Layout initialization

Layer / File(s) Summary
Fixed-text layout initialization
src/NLog/Layouts/Layout.cs, src/NLog/Layouts/SimpleLayout.cs		 Layout.Empty now uses the default SimpleLayout. Fixed-text SimpleLayout instances set IsInitialized and ThreadAgnostic to true.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 6ece3

Fixed-text layouts receive the intended initialization flags, with no established merge-blocking behavior.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ❓ Inconclusive No pull request description was provided, so the changeset intent and implementation details are not documented. Add a brief description that explains the initialization and thread-agnostic changes in Layout.Empty and SimpleLayout.
✅ Passed checks (3 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title accurately identifies the main change: literal layouts are initialized immediately and marked thread-agnostic. It is specific and related to the changeset.
  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks the layout trail
Empty paths now follow the default tale
Fixed text wakes already prepared
Thread-safe flags are clearly declared
Soft paws hop through initialized code

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

sonarqubecloud Bot commented Sep 13, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@snakefoot
snakefoot merged commit 85c0710 into NLog:dev Sep 13, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

size/XS

Projects

None yet

Milestone

6.2.1

Development

Successfully merging this pull request may close these issues.

1 participant

@snakefoot