Visitar URL original
Remove Microsoft.SourceLink.GitHub as part of NET8 SDK by snakefoot · Pull Request #6297 · NLog/NLog · GitHub
Skip to content

Remove Microsoft.SourceLink.GitHub as part of NET8 SDK - #6297

Merged
snakefoot merged 1 commit into
NLog:devfrom
snakefoot:NoSourceLink
Oct 7, 2026
Merged

Remove Microsoft.SourceLink.GitHub as part of NET8 SDK#6297
snakefoot merged 1 commit into
NLog:devfrom
snakefoot:NoSourceLink

Conversation

@snakefoot

@snakefoot snakefoot commented Oct 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

https://github.com/dotnet/sourcelink/releases

Source Link is now included in .NET SDK 8 and enabled by default. Projects that migrate to .NET SDK 8 do not need to reference Source Link packages explicitly via PackageReference anymore.

@coderabbitai

coderabbitai Bot commented Oct 7, 2026 •
edited
Loading

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 29244f39-899a-4b2e-b885-365e041e79c3
📥 Commits

Reviewing files that changed from the base of the PR and between 08e4aed and fa164e8.

📒 Files selected for processing (5)
  • src/NLog.OutputDebugString/NLog.OutputDebugString.csproj
  • src/NLog.RegEx/NLog.RegEx.csproj
  • src/NLog.Targets.AtomicFile/NLog.Targets.AtomicFile.csproj
  • src/NLog.Targets.GZipFile/NLog.Targets.GZipFile.csproj
  • src/NLog/NLog.csproj
💤 Files with no reviewable changes (5)
  • src/NLog.OutputDebugString/NLog.OutputDebugString.csproj
  • src/NLog.RegEx/NLog.RegEx.csproj
  • src/NLog/NLog.csproj
  • src/NLog.Targets.GZipFile/NLog.Targets.GZipFile.csproj
  • src/NLog.Targets.AtomicFile/NLog.Targets.AtomicFile.csproj

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

Walkthrough

Five project files remove their Microsoft.SourceLink.GitHub package reference. No public declarations changed.

Changes

SourceLink package reference removal

Layer / File(s) Summary
Remove package references
src/NLog.OutputDebugString/NLog.OutputDebugString.csproj, src/NLog.RegEx/NLog.RegEx.csproj, src/NLog.Targets.AtomicFile/NLog.Targets.AtomicFile.csproj, src/NLog.Targets.GZipFile/NLog.Targets.GZipFile.csproj, src/NLog/NLog.csproj		 Each project file no longer declares the Microsoft.SourceLink.GitHub package reference, including its version and PrivateAssets setting.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Merge Risk: ⚪ Minimal · up to fa164

The package-reference removals appear mergeable after normal build and packaging checks.

🚥 Pre-merge checks | ✅ 4 | ❓ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive No pull request description was provided, so the changeset has no author-provided description. Add a brief description that states Microsoft.SourceLink.GitHub was removed from the affected project files and explains the .NET 8 SDK context.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly identifies the main change: removal of Microsoft.SourceLink.GitHub package references from the projects as part of the .NET 8 SDK update.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks the project rows,
And finds five references gone.
No public names have changed their shape,
The files now carry fewer lines,
Then hops beneath the SourceLink dawn.

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

sonarqubecloud Bot commented Oct 7, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@snakefoot
snakefoot merged commit 2e61e01 into NLog:dev Oct 7, 2026
6 checks passed
@snakefoot snakefoot added this to the 6.2.2 milestone Oct 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

build-config size/S

Projects

None yet

Milestone

6.2.2

Development

Successfully merging this pull request may close these issues.

1 participant

@snakefoot