Change methods to static - #6355

No actionable comments were generated in the recent review.

Walkthrough

Two methods in separate NLog components changed from instance methods to static methods. Their parameters and described behavior remain unchanged.

Changes

Static Method Declarations

Estimated code review effort: 1 (Trivial) | ~3 minutes

Merge Risk: Minimal · up to 2f08a

This change makes two methods static without altering their behavior. No concrete user or production risk has been identified, so it is ready to merge after the normal build and test checks.

Pre-merge checks: 4

Check name	Status	Explanation
Title check		The title "Change methods to static" names the main change: two methods become static. The raw summary confirms CreateUnixStream in AtomicFileTarget.cs and EndXmlDocument in XmlElementBase.cs changed …
Description check		The description "Change two methods to static" relates directly to the changeset. It states the same change as the summary, though it gives no method names.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Title check

Explanation

The title "Change methods to static" names the main change: two methods become static. The raw summary confirms CreateUnixStream in AtomicFileTarget.cs and EndXmlDocument in XmlElementBase.cs changed from instance to static. The title does not name the methods, so it is somewhat broad, but it still matches the changeset.

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

_{I’m a rabbit, ears held high,
Two static methods catch my eye.
Their work and inputs stay the same,
Just static now beside each name.
I nibble clover, hop away.}

Recent review info

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Repository UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 20e822eb-0d13-4d7c-8df2-9bdf7ace8544

Commits

Reviewing files that changed from the base of the PR and between 148b075 and 2f08a9d.

Files selected for processing: 2

• src/NLog.Targets.AtomicFile/AtomicFileTarget.cs
• src/NLog/Layouts/XML/XmlElementBase.cs

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 6 remain after this review.

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.61%. Comparing base (148b075) to head (2f08a9d).

@@            Coverage Diff             @@
##             main    #6355      +/-   ##
==========================================
- Coverage   73.63%   73.61%   -0.02%     
==========================================
  Files         341      341              
  Lines       20795    20795              
  Branches     5282     5282              
==========================================
- Hits        15313    15309       -4     
- Misses       3828     3829       +1     
- Partials     1654     1657       +3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.