Visitar URL original
fix(recipe): resubmit the renamed GLM-5.2 Slurm script by MaxFreedomPollard · Pull Request #135 · NVIDIA-NeMo/labs-molt · GitHub
Skip to content

fix(recipe): resubmit the renamed GLM-5.2 Slurm script - #135

Merged
hijkzzz merged 1 commit into
NVIDIA-NeMo:mainfrom
MaxFreedomPollard:fix/glm52-resubmit-script
Sep 20, 2026
Merged

hijkzzz merged 1 commit into
NVIDIA-NeMo:mainfrom
MaxFreedomPollard:fix/glm52-resubmit-script

Conversation

@MaxFreedomPollard

Copy link
Copy Markdown
Contributor

The GLM-5.2 recipe still passes rl_glm5_2.sh to sbatch when CHAIN_MAX enables automatic resubmission. That file was renamed to rl_glm5_2_753b.sh, so the successor submission fails before training starts.

Use the current filename, keeping the repository-root path needed when Slurm runs its spool copy.

Validation: bash -n and Python compile checks pass. Exercising the chain block with a stubbed sbatch fails on the old path and succeeds with the new path, including the incremented chain depth and LOAD_ENABLE=1. No Slurm jobs were submitted. The Python test suite cannot collect in this environment because the training dependencies are not installed.

Signed-off-by: Max Freedom Pollard <272618364+MaxFreedomPollard@users.noreply.github.com>
@copy-pr-bot

copy-pr-bot Bot commented Sep 20, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@hijkzzz
hijkzzz merged commit 36fe51c into NVIDIA-NeMo:main Sep 20, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants