Repository navigation
Update DevelopmentWorkflow.md for v6 #7745
Description
Activity
Unfortunately, that did not work either. Reproduction steps:
$ node --version v10.16.0 $tns --version 6.0.3 $ git clone https://github.com/NativeScript/NativeScript $ tns create v6test --ng --appid com.rynop.v6test $ cd v6test $ npm install --save ../NativeScript/tns-core-modules + tns-core-modules@6.2.0 $ grep tns-core package.json "tns-core-modules": "file:../NativeScript/tns-core-modules",tns run iosto emulator, crashes. Full log hereI then:
$ cd ../NativeScript && npm installFrom here I can't determine the recommended way to compile (tsc). Is it
npm run compile-all? Is itnpm run tsc-w? I'm going to be making changes to tns-core-modules AND tns-core-modules-widgets so my guess isnpm run tsc-w. A clear recommendation needs to be documented inDevelopmentWorkflow.md.$ npm run tsc-wIn another tab:
$ cd projects/v6test $ tns run iosCrashes again, this time with a different error:
CONSOLE ERROR file:///src/Users/ryan/projects/NativeScript/tns-core-modules/trace/trace.ts:184:30 Error: Could not load CSS from app.css: TypeError: Expected module identifier to be a string.
Full log here.
Hopefully this helps you reproduce. Thanks in advance for your help as I'm blocked on this.
I got the same exact error CONSOLE ERROR file:///src/Users/ryan/projects/NativeScript/tns-core-modules/trace/trace.ts:184:30 Error: Could not load CSS from app.css: TypeError: Expected module identifier to be a string.
Same error here, any fix?
I'll make a new issue that is specifically targeted at this error.
Reacted by Zama Khan Mohammed and Vladyslav Piskunov@vpiskunov @mohammedzamakhan please try reproduction steps mentioned in the new issue above. Note you need to update master to pull in v6.1.0 release.
If you are able to reproduce, I'd appreciate a thumbs up or some comment in new issue to help get some visibility. I've been blocked for ~2wks. My hope is I'm just doing something stupid / missing a step.
FWIW since v6.1.0 the crash is manifesting itself without the error message noted in this issue.
I simply created a new nativescirpt app using Angular CLI after installing nativescript schematics
npm i -g @nativescript/schematicsusing the commandng new --schematics=@nativescript/schematics HelloWorldand ran preview using
npx --p nativescript tns preview, and I get this errorReacted by Ryan PendergastFor anyone getting the
Error: Could not load CSS from app.css: TypeError: Expected module identifier to be a string.css issue.Update
nativescript-dev-webpackto 1.2 (npm install --save-dev nativescript-dev-webpack) as per @elena-p comment here: https://github.com/NativeScript/nativescript-angular/issues/1975#issuecomment-530243719 .I had this issue and upgrading
nativescript-dev-webpackfixed it.Reacted by Ryan Pendergast, Demetrio Filocamo and Marvin KruegerHi all,
The problem with the modules linking for NativeScript Angular projects seems to be connected to nativescript-dev-webpack. I am closing this issue in favour of NativeScript/nativescript-dev-webpack#1044Should
npm run tsc-wbe added toDevelopmentWorkflow.md? Or one of the other compile scripts in package.json? For example, following https://github.com/NativeScript/NativeScript/blob/master/DevelopmentWorkflow.md#running-another-app will not work unless some sort of compile is done. Atns-core-modules*noob like me was/is not clear on the recommended way.
I'm trying to test a contribution to the v6
tns-core-modulesandtns-core-modules-widgets, and running into problems following the DevelopmentWorkflow.md. I think it is outdated.In short, I want to modify a
.tsfile intns-core-modulesand be able to test the modification in a v6 NativeScript app in another directory.A few issues with the current DevelopmentWorkflow.md:
npm install) does not npm linkscripttarget to run. My hunch is it isdev-tsc-allbut this script has a bug in it (pr below) AND after running, the.jsfiles end up inbin/dist/tns-core-modules/without apackage.json(sonpm linkwill not work).compile-allscript does the same.dev-link-tns-core-modules-widgetsscript references adist/packagedir that DNE.I'm happy to do the work to PR an update to the docs, however I need some clarity on the right way to do it 1st.
Here is my workflow - what am I doing wrong?
git checkout -b my-feature/fix-branchnpm installnpm run compile-allnpm link ../<where I cloned>/tns-core-modules-widgets/ && npm link ../<where I cloned>/tns-core-modulestns debug ios --debug-brk --env.sourceMap