Visitar URL original
feat(imagepicker): use PHPickerViewController on iOS, add onProgress by sitefinitysteve · Pull Request #681 · NativeScript/plugins · GitHub
Skip to content

feat(imagepicker): use PHPickerViewController on iOS, add onProgress #681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sitefinitysteve wants to merge 9 commits into
base: main
Choose a base branch
from
Open

feat(imagepicker): use PHPickerViewController on iOS, add onProgress #681

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
8dd4218
feat(imagepicker): use PHPickerViewController on iOS
sitefinitysteve Sep 11, 2026
820d66e
imagepicker: copy files off the main thread
sitefinitysteve Sep 11, 2026
e966c59
imagepicker: add optional onProgress callback
sitefinitysteve Sep 11, 2026
048064d
imagepicker demo: pace progress display so ticks are visible
sitefinitysteve Sep 11, 2026
d5096ef
imagepicker demo: restyle page to match demo app
sitefinitysteve Sep 11, 2026
9fdacc9
imagepicker: present on main thread once active, dismiss before resol…
sitefinitysteve Sep 11, 2026
ca91db4
imagepicker demo: present the picker even without photo access
sitefinitysteve Sep 11, 2026
f89742a
imagepicker: add an on-device recording of the PHPicker flow
sitefinitysteve Sep 11, 2026
309c402
imagepicker demo: spell out that the progress pacing is display-only
sitefinitysteve Sep 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
imagepicker demo: present the picker even without photo access
  • Loading branch information
@sitefinitysteve
sitefinitysteve committed Sep 11, 2026
commit ca91db44d29e6ded3955bea2aaaf24e2b0991031
68 changes: 30 additions & 38 deletions tools/demo/imagepicker/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { DemoSharedBase } from '../utils';
import * as imagepicker from '@nativescript/imagepicker';
import { Dialogs, ImageAsset, ImageSource } from '@nativescript/core';
import { ImageAsset, ImageSource } from '@nativescript/core';

export class DemoSharedImagepicker extends DemoSharedBase {
private _selection: any;
Expand Down Expand Up @@ -182,48 +182,40 @@ export class DemoSharedImagepicker extends DemoSharedBase {
}

private startSelection(context: imagepicker.ImagePicker) {
// The system picker runs out of process and works without photo-library
// access, so present it either way. With access the picks resolve to
// their PHAsset; without it the picker hands over a copy of each file.
context
.authorize()
.then((authResult) => {
console.log(authResult);
if (authResult.authorized) {
this.clear();
return context
.present()
.then((selection: imagepicker.ImagePickerSelection[]) => {
console.log('Selection done: ', selection);
// Let the paced progress display finish before showing the results.
return this.draining.then(() => selection);
})
.then((selection: imagepicker.ImagePickerSelection[]) => {
this.progressText = null;
this.imageSrc = this.isSingleMode && selection.length > 0 ? selection[0].asset : null;
if (selection[0].thumbnail) {
this.imageSrc = selection[0].thumbnail;
}
this.selection = this.isSingleMode && selection.length > 0 ? selection[0] : null;

// set the images to be loaded from the assets with optimal sizes (optimize memory usage)
selection.forEach((element) => {
// Full paths are long (especially on the simulator); show the tail.
(element as any).shortPath = '…/' + (element.path || '').split('/').slice(-3).join('/');
let asset = element.asset;
asset.options.width = this.isSingleMode ? this.previewSize : this.thumbSize;
asset.options.height = this.isSingleMode ? this.previewSize : this.thumbSize;
});

this.imageAssets = selection;
this.notifyPropertyChange('hasResults', this.hasResults);
});
} else {
console.log('UnAuthorized');
// iOS never re-prompts once access has been denied.
Dialogs.alert({
title: 'Photo access denied',
message: 'Allow photo access for this app in Settings and try again.',
okButtonText: 'OK',
});
this.clear();
return context.present();
})
.then((selection: imagepicker.ImagePickerSelection[]) => {
console.log('Selection done: ', selection);
// Let the paced progress display finish before showing the results.
return this.draining.then(() => selection);
})
.then((selection: imagepicker.ImagePickerSelection[]) => {
this.progressText = null;
this.imageSrc = this.isSingleMode && selection.length > 0 ? selection[0].asset : null;
if (selection[0].thumbnail) {
this.imageSrc = selection[0].thumbnail;
}
this.selection = this.isSingleMode && selection.length > 0 ? selection[0] : null;

// set the images to be loaded from the assets with optimal sizes (optimize memory usage)
selection.forEach((element) => {
// Full paths are long (especially on the simulator); show the tail.
(element as any).shortPath = '…/' + (element.path || '').split('/').slice(-3).join('/');
let asset = element.asset;
asset.options.width = this.isSingleMode ? this.previewSize : this.thumbSize;
asset.options.height = this.isSingleMode ? this.previewSize : this.thumbSize;
});

this.imageAssets = selection;
this.notifyPropertyChange('hasResults', this.hasResults);
})
.catch(function (e) {
console.log('selection error', e);
Expand Down