Visitar URL original
SpikeGLX: fix `event_count` returning channel 0's count for every digital channel by h-mayorquin · Pull Request #1951 · NeuralEnsemble/python-neo · GitHub
Skip to content

SpikeGLX: fix event_count returning channel 0's count for every digital channel - #1951

Open
h-mayorquin wants to merge 1 commit into
NeuralEnsemble:masterfrom
h-mayorquin:fix_spikeglx_count
Open

h-mayorquin wants to merge 1 commit into
NeuralEnsemble:masterfrom
h-mayorquin:fix_spikeglx_count

Conversation

@h-mayorquin

Copy link
Copy Markdown
Contributor

While checking how each reader times its segments for #1937 I noticed that SpikeGLXRawIO._event_count takes its arguments in a different order from the base class, so the block index is used as the channel. On spikeglx/DigitalChannelTest_g0 event_count gives 326 for all eight digital channels while get_event_timestamps returns 326 events for XD0 and none for the other seven.

This PR puts the arguments in the base class order. I added that file to entities_to_test, where the shared read_events check fails on master with Wrong shape 0, 326. Before this the file was only read by test_nidq_digital_channel and never went through the shared checks. This is another case for #1945.

@h-mayorquin
h-mayorquin requested a review from alejoe91 November 6, 2026 19:43

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant