Repository navigation
SpikeGLX: fix event_count returning channel 0's count for every digital channel - #1951
Open
h-mayorquin wants to merge 1 commit into
Open
h-mayorquin wants to merge 1 commit into
h-mayorquin wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While checking how each reader times its segments for #1937 I noticed that
SpikeGLXRawIO._event_counttakes its arguments in a different order from the base class, so the block index is used as the channel. Onspikeglx/DigitalChannelTest_g0event_countgives 326 for all eight digital channels whileget_event_timestampsreturns 326 events forXD0and none for the other seven.This PR puts the arguments in the base class order. I added that file to
entities_to_test, where the sharedread_eventscheck fails on master withWrong shape 0, 326. Before this the file was only read bytest_nidq_digital_channeland never went through the shared checks. This is another case for #1945.