Visitar URL original
[18.0][MIG] delivery_easypost_oca: Migration to 18.0 by antoniodavid · Pull Request #1082 · OCA/delivery-carrier · GitHub
Skip to content

[18.0][MIG] delivery_easypost_oca: Migration to 18.0 - #1082

Merged
OCA-git-bot merged 3 commits into
OCA:18.0from
BinhexTeam:18.0-mig-delivery_easypost_oca
Jan 19, 2026
Merged

[18.0][MIG] delivery_easypost_oca: Migration to 18.0#1082
OCA-git-bot merged 3 commits into
OCA:18.0from
BinhexTeam:18.0-mig-delivery_easypost_oca

Conversation

@antoniodavid

@antoniodavid antoniodavid commented Nov 14, 2025 •
edited
Loading

Copy link
Copy Markdown

@BinhexTeam T17881

@antoniodavid
antoniodavid force-pushed the 18.0-mig-delivery_easypost_oca branch 2 times, most recently from 27c91f2 to 7877489 Compare November 17, 2025 18:05
@antoniodavid antoniodavid mentioned this pull request Nov 17, 2025
Merged
@antoniodavid
antoniodavid force-pushed the 18.0-mig-delivery_easypost_oca branch from 7877489 to eae4287 Compare November 17, 2025 20:00
@antoniodavid
antoniodavid force-pushed the 18.0-mig-delivery_easypost_oca branch from eae4287 to 8288498 Compare November 17, 2025 20:11
@antoniodavid

antoniodavid commented Nov 17, 2025

Copy link
Copy Markdown
Author

@jelenapoblet @rrebollo @edescalona @crrodrigueztrujillo please, I need some reviews.

rrebollo
rrebollo approved these changes Nov 24, 2025
View reviewed changes

@rrebollo rrebollo left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review: Great work! The code looks good to me (LGTM). Thank you for your contribution! I've provided a few suggestions for your consideration—feel free to address them as you see fit.

Comment thread delivery_easypost_oca/models/delivery_carrier.py

from markupsafe import Markup

from odoo import _, fields, models

@rrebollo rrebollo Nov 24, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
from odoo import _, fields, models
from odoo import fields, models

The recommended way to use translation in odoo 18 is self.env._

Comment thread delivery_easypost_oca/tests/common.py
# Set company currency to USD to match EasyPost rates
usd_currency = cls.env.ref("base.USD")
cls.env.company.currency_id = usd_currency

@rrebollo rrebollo Nov 24, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if tracking is not relevant for your tests you could disable it

edescalona
edescalona approved these changes Dec 2, 2025
View reviewed changes

@edescalona edescalona left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot

OCA-git-bot commented Dec 2, 2025

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@hparfr

hparfr commented Jan 19, 2026

Copy link
Copy Markdown

/ocabot migration delivery_easypost_oca

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Jan 19, 2026
@OCA-git-bot OCA-git-bot mentioned this pull request Jan 19, 2026
Open
40 of 46 tasks
hparfr
hparfr approved these changes Jan 19, 2026
View reviewed changes

@hparfr hparfr left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot

OCA-git-bot commented Jan 19, 2026

Copy link
Copy Markdown
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 18.0-ocabot-merge-pr-1082-by-hparfr-bump-nobump, awaiting test results.

@OCA-git-bot
OCA-git-bot merged commit b40f20e into OCA:18.0 Jan 19, 2026
3 checks passed
@OCA-git-bot

OCA-git-bot commented Jan 19, 2026

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at c88fb76. Thanks a lot for contributing to OCA. ❤️

@atgalvez08
atgalvez08 deleted the 18.0-mig-delivery_easypost_oca branch November 13, 2026 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dreispt dreispt dreispt approved these changes
@hparfr hparfr hparfr approved these changes
+2 more reviewers
@rrebollo rrebollo rrebollo approved these changes
@edescalona edescalona edescalona approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved merged 🎉 ready to merge

Projects

None yet

Milestone

18.0

Development

Successfully merging this pull request may close these issues.

6 participants

@antoniodavid @OCA-git-bot @hparfr @dreispt @rrebollo @edescalona