Visitar URL original
feat: Use generated email templates by hhvrc · Pull Request #305 · OpenShock/API · GitHub
Skip to content

feat: Use generated email templates - #305

Merged
LucHeart merged 15 commits into
developfrom
feature/react-email-templates
May 26, 2026
Merged

feat: Use generated email templates#305
LucHeart merged 15 commits into
developfrom
feature/react-email-templates

Conversation

@hhvrc

@hhvrc hhvrc commented May 24, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@hhvrc hhvrc self-assigned this May 24, 2026
Copilot AI review requested due to automatic review settings May 24, 2026 17:07
@hhvrc hhvrc added the feature New feature or request label May 24, 2026
Copilot AI reviewed May 24, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Introduces a React-Email + pnpm-based source-of-truth for the API’s transactional SMTP templates and generates the Liquid files during dotnet build/publish, replacing the previously committed .liquid templates.

Changes:

  • Add API/SmtpTemplates Node workspace (React-Email templates + exporter) and supporting TypeScript config/docs.
  • Update API/API.csproj to (1) install template deps, (2) export .liquid files, and (3) include generated templates as publish/output content.
  • Update Docker/CI workflows to ensure Node + pnpm are available during builds that publish the API.

Reviewed changes

Copilot reviewed 20 out of 21 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
docker/API.Dockerfile Installs Node + pnpm in the API build stage so MSBuild template generation can run during publish.
API/API.csproj Adds MSBuild targets to install deps, export Liquid templates, and include generated .liquid files in output/publish.
API/SmtpTemplates/package.json Defines the React-Email workspace, scripts (dev/export), and pins toolchain/deps.
API/SmtpTemplates/pnpm-lock.yaml Locks Node dependencies for deterministic template builds.
API/SmtpTemplates/tsconfig.json TypeScript configuration for the template workspace.
API/SmtpTemplates/scripts/export-templates.ts Exports .tsx templates into dist/*.liquid with subject on line 1.
API/SmtpTemplates/README.md Documents how templates build via MSBuild and how to develop/export locally.
API/SmtpTemplates/.gitignore Ignores node_modules, build outputs, and React-Email dev artifacts.
API/SmtpTemplates/emails/EmailVerification.tsx React-Email version of the email verification template.
API/SmtpTemplates/emails/PasswordReset.tsx React-Email version of the password reset template.
API/SmtpTemplates/emails/EmailChangeNotice.tsx React-Email version of the email change notice template.
API/SmtpTemplates/emails/AccountActivation.tsx React-Email version of the account activation template.
API/SmtpTemplates/emails/_lib/components.tsx Shared React-Email building blocks (layout, paragraph, CTA button, etc.).
API/SmtpTemplates/emails/_lib/styles.ts Shared inline style definitions for templates.
API/SmtpTemplates/emails/_lib/placeholders.ts Utility to convert sampleProps keys into Liquid placeholders during export.
API/SmtpTemplates/EmailVerification.liquid Removes committed Liquid template (now generated).
API/SmtpTemplates/PasswordReset.liquid Removes committed Liquid template (now generated).
API/SmtpTemplates/EmailChangeNotice.liquid Removes committed Liquid template (now generated).
API/SmtpTemplates/AccountActivation.liquid Removes committed Liquid template (now generated).
.github/workflows/ci-build.yml Installs Node + pnpm in CI because API build/test now generates templates.
.github/workflows/codeql.yml Installs Node + pnpm for CodeQL job because API publish now generates templates.
Files not reviewed (1)
  • API/SmtpTemplates/pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread API/API.csproj Resolved
Comment thread docker/API.Dockerfile Resolved
Comment thread email-templates/emails/AccountActivation.tsx Resolved
Comment thread .github/workflows/ci-build.yml Resolved
Comment thread .github/workflows/codeql.yml Resolved
@hhvrc
hhvrc requested a review from Copilot May 26, 2026 14:25
Copilot AI reviewed May 26, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@hhvrc
hhvrc requested a review from Copilot May 26, 2026 15:03
Copilot AI reviewed May 26, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 33 out of 35 changed files in this pull request and generated 7 comments.

Files not reviewed (1)
  • email-templates/pnpm-lock.yaml: Language not supported

Comment thread email-templates/emails/_lib/styles.ts Resolved
Comment thread email-templates/README.md Resolved
Comment thread API/Services/Email/Mailjet/MailjetEmailService.cs Resolved
Comment thread API/Services/Email/Mailjet/Mail/MailsWrap.cs Resolved
Comment thread API/Services/Email/Mailjet/Mail/DirectMail.cs Resolved
Comment thread API/Services/Email/Mailjet/Mail/DirectMail.cs Resolved
Comment thread API/Services/Email/EmailServiceExtension.cs Resolved
LucHeart and others added 4 commits May 26, 2026 17:58
@LucHeart
fix logo
674c7a0
@LucHeart
Potential fix for pull request finding
c6744fe 
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@LucHeart
Potential fix for pull request finding
4bc8376 
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@LucHeart
Fix email template setup
c83080e
@LucHeart
LucHeart merged commit db52638 into develop May 26, 2026
23 checks passed
@LucHeart
LucHeart deleted the feature/react-email-templates branch May 26, 2026 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Assignees

@hhvrc hhvrc

Labels

feature New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hhvrc @LucHeart