Visitar URL original
fix: replace per-hub update loop warnings with a metric by LucHeart · Pull Request #395 · OpenShock/API · GitHub
Skip to content

fix: replace per-hub update loop warnings with a metric - #395

Open
LucHeart wants to merge 1 commit into
masterfrom
hotfix/aggregate-update-loop-behind
Open

fix: replace per-hub update loop warnings with a metric#395
LucHeart wants to merge 1 commit into
masterfrom
hotfix/aggregate-update-loop-behind

Conversation

@LucHeart

@LucHeart LucHeart commented Nov 14, 2026

Copy link
Copy Markdown
Member

A gateway stall made every connected hub log a warning at once. Dropped ticks now feed openshock_hub_update_ticks_dropped, the per-hub message is demoted to debug, and severe lag (>=1s) logs a single error at most every 30s gateway-wide.

What does this change?

How was it tested?

Checklist

  • The change is focused on one thing.
  • Tests, formatter and linter pass locally.
  • Documentation is updated where behaviour changed.
  • No secrets, credentials or personal data are included.
  • If this touches device control, limits, sharing, authentication or firmware updates, the description says so and explains how it was tested.

@LucHeart
fix: replace per-hub update loop warnings with a metric
5c3ee85 
A gateway stall made every connected hub log a warning at once. Dropped
ticks now feed openshock_hub_update_ticks_dropped, the per-hub message
is demoted to debug, and severe lag (>=1s) logs a single error at most
every 30s gateway-wide.
@coderabbitai

coderabbitai Bot commented Nov 14, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 7918186b-4c45-48cf-a224-887e0bc83804

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-14T03:24:59.173913Z 5c3ee85 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@LucHeart