Visitar URL original
fix(host-service): treat a socket torn down mid-request as the cloud being unreachable by saddlepaddle · Pull Request #7680 · ParadevAI/Paradev · GitHub
Skip to content

fix(host-service): treat a socket torn down mid-request as the cloud being unreachable - #7680

Merged
saddlepaddle merged 1 commit into
mainfrom
sentry/host-service-6s-enotconn
Sep 20, 2026
Merged

fix(host-service): treat a socket torn down mid-request as the cloud being unreachable#7680
saddlepaddle merged 1 commit into
mainfrom
sentry/host-service-6s-enotconn

Conversation

@saddlepaddle

@saddlepaddle saddlepaddle commented Sep 20, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Collaborator

Problem

host.info calls the cloud API to resolve the organization. When that request dies in transport, the host-service already knows not to report it: #6735 added rethrowCloudUnreachable, which walks the cause chain for a transport code and rethrows as SERVICE_UNAVAILABLE so the tRPC Sentry middleware leaves it alone.

One transport code was missing from that set. A machine whose socket to the API was torn down mid-request surfaced as a fresh host-service INTERNAL_SERVER_ERROR issue, i.e. reported as our bug.

Root cause

The failure arrives as the usual three-link chain — TRPCClientError("fetch failed") → TypeError("fetch failed") → a Node socket error carrying code: "ENOTCONN". That is the identical shape to the read ECONNRESET case the classifier already covers (and which its tests already name), but ENOTCONN was never in UNREACHABLE_CODES, so findUnreachableCause returned null and the error fell through to the middleware as a 500.

The middleware's contract is explicit: anything still INTERNAL_SERVER_ERROR at that boundary is a bug, and the remedy is to fix the missing translation at the throw site rather than filter at the middleware. This is that missing translation.

Fix

One entry added to the existing code set, plus the matching row in the existing table-driven test. Nothing else: only the code this issue actually produced is added. Sibling codes that have never been observed here (EPIPE, ECONNABORTED, …) are deliberately left out — a classifier that matches more than the condition it names would silence real failures, which is why the set is grown from observed evidence one code at a time.

ENOTCONN on a read means the socket was not connected when the read happened: the peer, a proxy, or the network between the user and the API dropped it. It cannot describe a defect in host-service's own call, and the only errors that reach this classifier are the ones thrown by that single cloud API call.

No behaviour change for any consumer: the desktop's readHostServiceInfo already catches a failing host.info and omits the optional fields, and isHostServiceConnectionError already treats SERVICE_UNAVAILABLE as retryable/connection-level.

Verification

Test row added first, and confirmed failing against unchanged source:

(fail) rethrowCloudUnreachable > ENOTCONN is the cloud being unreachable [0.09ms]
Expected: "SERVICE_UNAVAILABLE"
Received: undefined
 21 pass
 1 fail

After the one-line source change:

$ bun test src/trpc/router/host/
 22 pass
 0 fail
 39 expect() calls
Ran 22 tests across 1 file. [23.00ms]

$ bunx biome check packages/host-service/src/trpc/router/host/cloud-api-error.ts packages/host-service/src/trpc/router/host/cloud-api-error.test.ts
Checked 2 files in 15ms. No fixes applied.

$ cd packages/host-service && bun run typecheck
$ tsc --noEmit --emitDeclarationOnly false
(clean)

No user-facing strings touched, so check:i18n does not apply.

Refs HOST-SERVICE-6S

Summary by cubic

Fixes host.info reporting ENOTCONN socket errors as internal server errors. A socket torn down mid-request to the cloud API is now classified as the cloud being unreachable and rethrown as SERVICE_UNAVAILABLE, so it no longer surfaces as a host-service bug. Adds ENOTCONN to the unreachable codes set plus a matching test row. No consumer behavior changes. Fixes HOST-SERVICE-6S.

Written for commit acb4655. Summary will update on new commits.

Review in cubic

Summary by CodeRabbit

  • Bug Fixes
    • Socket connection failures are now correctly reported as a service unavailable error instead of an internal server error.
    • The original error message is preserved for improved troubleshooting.

@saddlepaddle
fix(host-service): treat a socket torn down mid-request as the cloud …
acb4655 
…being unreachable

ENOTCONN reaches the cloud-unreachable classifier in the same shape ECONNRESET already does, but was not in the code set, so a dropped socket kept being reported as a host-service 500.
@coderabbitai

coderabbitai Bot commented Sep 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 0ca09328-f68e-480e-9c99-614dde27e165

📥 Commits

Reviewing files that changed from the base of the PR and between e60856b and acb4655.

📒 Files selected for processing (2)
  • packages/host-service/src/trpc/router/host/cloud-api-error.test.ts
  • packages/host-service/src/trpc/router/host/cloud-api-error.ts

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.

📝 Walkthrough

Walkthrough

The change treats ENOTCONN socket errors as cloud-unreachable failures. The handler rethrows them as SERVICE_UNAVAILABLE, and the test verifies that the original message remains unchanged.

Changes

Cloud unreachable error handling

Layer / File(s) Summary
ENOTCONN mapping and validation
packages/host-service/src/trpc/router/host/cloud-api-error.ts, packages/host-service/src/trpc/router/host/cloud-api-error.test.ts		 ENOTCONN is added to the unreachable error codes. The parameterized test verifies the SERVICE_UNAVAILABLE result and preserved message.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title uses conventional commit format and clearly describes the main change: classifying mid-request socket teardown as cloud unreachability.
Description check ✅ Passed The description clearly explains the problem, root cause, fix, scope, references, and verification results. It does not use the template headings or include the checklist, but it provides the required…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

🧹 Preview Cleanup Complete

The following preview resources have been cleaned up:

  • ✅ Neon database branch

Thank you for your contribution! 🎉

@saddlepaddle
saddlepaddle merged commit bf2ce10 into main Sep 20, 2026
24 checks passed
@Kitenite Kitenite mentioned this pull request Sep 23, 2026
Merged
4 tasks done
Kitenite added a commit that referenced this pull request Sep 23, 2026
@Kitenite
docs: update product guides and trim redundant instructions (#7771)
033439d 
* docs: update weekly product documentation for September 23

Source of truth: live Notion SOP https://www.notion.so/3b3b9d5bf616810dbacaca7dd2305259
Window: GitHub merged:>=2026-09-16, through this run on 2026-09-23. gh returned 103 PRs (limit 1000, avoiding the SOP example’s 50-PR truncation).
Workspace baseline: 2158895. Prior session stopped at a usage limit; the checkout was clean.

## Changes

- Pages, CLI, and MCP: public sharing, workspace menus, origin labels, pagination, first-publish opening, version previews, mobile comments, and link handling: #7570, #7658, #7726, #7472, #7532, #7718. Files: pages.mdx; cli/cli-reference.mdx; mcp-server.mdx.
- iPhone launch, requirements, setup, host states, and Pro checklist: #7703, #7686, #7697, #7661, #7642, #7494. Files: install.mdx; faq.mdx; overview.mdx; remote-access.mdx.
- Editor save conflicts and Markdown link actions: #7711, #7621. Files: editor.mdx.
- Terminal locations, copying, and ended-session recovery: #7712, #7709, #7618. Files: terminal-integration.mdx.
- Model catalog, embedded sign-in, and leaderboard history: #7741, #7740, #7651. Files: agent-integration.mdx; usage.mdx; cli/cli-reference.mdx.
- Repository picker, cloud working branches and attachments, mobile sessions, sidebar naming and ordering: #7694, #7620, #7622, #7633, #7604, #7650, #7575. Files: first-workspace.mdx; workspaces.mdx.
- Slack plugin tools and gated thread follow-ups, queuing, mute and stop controls: #7583, #7585, #7586, #7588, #7592, #7594. Files: use-with-slack.mdx.
- New CLI transcript, environment, and page deletion commands; connected-service plugins and MCP CLI migration: #7602, #7317. Files: cli/cli-reference.mdx; skills.mdx.
- Startup recovery and pre-account workspace migration: #7764, #7649. Files: troubleshooting.mdx.

Current source wins over PR descriptions: page ordering is newest-created first, search includes description, default CLI output remains a bare array, and the leaderboard automatically backfills since launch (there is no history-range picker). Slack thread commands and Mobile settings retain their availability qualifications. No assumption that every merged fix is already in the latest download.

## Deliberately skipped

- [#7765](#7765) fix(host-service): report GitHub being unreachable as unavailable, not a 500: Reliability or visual fix restores expected behavior; no new workflow or necessary workaround to document.
- [#7756](#7756) fix(pages): restore page.list's bare-array contract for released clients: Restores compatibility for released clients; checked the current listPaginated implementation when documenting #7726.
- [#7749](#7749) fix(build): build every dist-types a filtered mobile typecheck needs: Internal build, tests, migration, developer tooling, or recovery plumbing; no new user-facing instructions.
- [#7748](#7748) feat(mobile): refresh the App Store listing and load review creds from .env: Marketing/store copy, layout, or launch assets; no separate product-doc change. The released iPhone workflow is covered by #7686 and #7703.
- [#7747](#7747) feat(mobile): ask for a rating on returning Home after real use: App Store rating timing needs no setup or reference instructions.
- [#7746](#7746) feat(mobile): start Sentry natively so launch crashes carry native context: Internal build, tests, migration, developer tooling, or recovery plumbing; no new user-facing instructions.
- [#7744](#7744) fix(email): make the welcome email unsubscribable via a Resend automation: Welcome email unsubscribe delivery is not a product workflow needing docs.
- [#7734](#7734) fix(desktop): restore locale provider test mocks: Internal build, tests, migration, developer tooling, or recovery plumbing; no new user-facing instructions.
- [#7733](#7733) fix(marketing): hide leaderboard vertical guide lines: Marketing/store copy, layout, or launch assets; no separate product-doc change. The released iPhone workflow is covered by #7686 and #7703.
- [#7732](#7732) chore(desktop): bump version to 1.30.2: Version bump only.
- [#7723](#7723) fix(desktop): preserve sidebar order and missing group members: Reliability or visual fix restores expected behavior; no new workflow or necessary workaround to document.
- [#7717](#7717) fix(desktop): keep terminal links within URL boundaries: Reliability or visual fix restores expected behavior; no new workflow or necessary workaround to document.
- [#7715](#7715) fix(ci): unblock CLI publishing and retry macOS installs: Internal build, tests, migration, developer tooling, or recovery plumbing; no new user-facing instructions.
- [#7714](#7714) fix(desktop): prevent tab close clicks from starting a drag: Reliability or visual fix restores expected behavior; no new workflow or necessary workaround to document.
- [#7710](#7710) feat(marketing): add Vladimir mobile testimonial and rank quotes: Marketing/store copy, layout, or launch assets; no separate product-doc change. The released iPhone workflow is covered by #7686 and #7703.
- [#7704](#7704) feat(marketing): add App Store icon to footer: Marketing/store copy, layout, or launch assets; no separate product-doc change. The released iPhone workflow is covered by #7686 and #7703.
- [#7701](#7701) chore(desktop): bump version to 1.30.1: Version bump only.
- [#7700](#7700) fix(marketing): refine hero copy and demo details: Marketing/store copy, layout, or launch assets; no separate product-doc change. The released iPhone workflow is covered by #7686 and #7703.
- [#7698](#7698) feat(marketing): replace mobile feature cards with customer testimonials: Marketing/store copy, layout, or launch assets; no separate product-doc change. The released iPhone workflow is covered by #7686 and #7703.
- [#7696](#7696) fix: write managed configs and workspace files through symlinks: Reliability or visual fix restores expected behavior; no new workflow or necessary workaround to document.
- [#7695](#7695) fix(marketing): isolate and scale the mobile phone demo: Marketing/store copy, layout, or launch assets; no separate product-doc change. The released iPhone workflow is covered by #7686 and #7703.
- [#7691](#7691) fix(terminal): preserve agent paste mode across host restarts: Reliability or visual fix restores expected behavior; no new workflow or necessary workaround to document.
- [#7690](#7690) feat(marketing): showcase mobile workflows and simplify the homepage: Marketing/store copy, layout, or launch assets; no separate product-doc change. The released iPhone workflow is covered by #7686 and #7703.
- [#7689](#7689) chore(mobile): bump version to 1.1.1 for TestFlight: Version bump only.
- [#7688](#7688) fix(desktop): resolve dev Dock names across workspace path aliases: Internal build, tests, migration, developer tooling, or recovery plumbing; no new user-facing instructions.
- [#7685](#7685) docs(marketing): add September 20 weekly changelog: Marketing/store copy, layout, or launch assets; no separate product-doc change. The released iPhone workflow is covered by #7686 and #7703.
- [#7684](#7684) docs(skills): share mobile demo recording and film tooling: Internal build, tests, migration, developer tooling, or recovery plumbing; no new user-facing instructions.
- [#7683](#7683) fix(ui): truncate the page title instead of running it under the header actions: Reliability or visual fix restores expected behavior; no new workflow or necessary workaround to document.
- [#7680](#7680) fix(host-service): treat a socket torn down mid-request as the cloud being unreachable: Reliability or visual fix restores expected behavior; no new workflow or necessary workaround to document.
- [#7678](#7678) fix(desktop): keep markdown link and image attributes as strings so a paste can't stop the editor saving: Reliability or visual fix restores expected behavior; no new workflow or necessary workaround to document.
- [#7676](#7676) docs(db): migration safety checklist and deploy workflow pitfalls from the 17 September outage: Internal build, tests, migration, developer tooling, or recovery plumbing; no new user-facing instructions.
- [#7675](#7675) fix(integrations): backfill existing connections into the table #7317 reads: Internal build, tests, migration, developer tooling, or recovery plumbing; no new user-facing instructions.
- [#7672](#7672) fix(ci): a failed production migration can no longer pass as a success: Internal build, tests, migration, developer tooling, or recovery plumbing; no new user-facing instructions.
- [#7671](#7671) fix(db,ci): make migration 0119 online-safe and bound production migrations: Internal build, tests, migration, developer tooling, or recovery plumbing; no new user-facing instructions.
- [#7670](#7670) fix(desktop): send text to running terminals as a bracketed paste, not raw keystrokes: Reliability or visual fix restores expected behavior; no new workflow or necessary workaround to document.
- [#7669](#7669) feat(skills): audit page usage in the 10x skill: Existing skills page already describes the 10x audit; page-usage audit is an internal skill refinement.
- [#7668](#7668) fix(mobile): scroll-to-bottom button drives Claude Code's fullscreen view: Reliability or visual fix restores expected behavior; no new workflow or necessary workaround to document.
- [#7666](#7666) fix(host-service): treat a gh that cannot start as no token: Internal build, tests, migration, developer tooling, or recovery plumbing; no new user-facing instructions.
- [#7665](#7665) chore(desktop): bump version to 1.30.0: Version bump only.
- [#7664](#7664) refactor(marketing): share the store badges with the mobile launch post: Marketing/store copy, layout, or launch assets; no separate product-doc change. The released iPhone workflow is covered by #7686 and #7703.
- [#7662](#7662) chore(mobile): simulator verification skill, stand-in host, and host-state flows: Internal build, tests, migration, developer tooling, or recovery plumbing; no new user-facing instructions.
- [#7659](#7659) fix(host-service): stop the Linux file watcher from taking the host down, and make superset start recover: Reliability or visual fix restores expected behavior; no new workflow or necessary workaround to document.
- [#7655](#7655) feat(marketing): add /mobile landing page behind the mobile-launch flag: Marketing/store copy, layout, or launch assets; no separate product-doc change. The released iPhone workflow is covered by #7686 and #7703.
- [#7647](#7647) fix(agent-setup): restore Codex working status: Reliability or visual fix restores expected behavior; no new workflow or necessary workaround to document.
- [#7644](#7644) fix(desktop): refresh commits after external changes: Reliability or visual fix restores expected behavior; no new workflow or necessary workaround to document.
- [#7643](#7643) fix(mobile): a long press lifts the whole session tab, not its text: Reliability or visual fix restores expected behavior; no new workflow or necessary workaround to document.
- [#7641](#7641) fix(desktop): harden renderer error boundaries and recovery: Reliability or visual fix restores expected behavior; no new workflow or necessary workaround to document.
- [#7639](#7639) fix(desktop): keep the editor selection valid when external content replaces the document: Reliability or visual fix restores expected behavior; no new workflow or necessary workaround to document.
- [#7638](#7638) fix(desktop): stop the file tree throwing when a lookup walks through a file: Reliability or visual fix restores expected behavior; no new workflow or necessary workaround to document.
- [#7636](#7636) fix(host-service): classify an index its storage cannot deliver as environmental: Reliability or visual fix restores expected behavior; no new workflow or necessary workaround to document.
- [#7615](#7615) fix(cli-framework,i18n): `bun run dev` runs the CLI instead of dying: Internal build, tests, migration, developer tooling, or recovery plumbing; no new user-facing instructions.
- [#7613](#7613) fix(host-service): a terminal in a cloud workspace knows it is in one: Internal build, tests, migration, developer tooling, or recovery plumbing; no new user-facing instructions.
- [#7611](#7611) feat(marketing): Superset Mobile launch post (hidden until launch): Marketing/store copy, layout, or launch assets; no separate product-doc change. The released iPhone workflow is covered by #7686 and #7703.
- [#7608](#7608) fix(sandbox): the release probe checks the display from inside the box: Internal build, tests, migration, developer tooling, or recovery plumbing; no new user-facing instructions.
- [#7606](#7606) fix(relay): tolerate slow connections with coordinated deadlines: Reliability or visual fix restores expected behavior; no new workflow or necessary workaround to document.
- [#7605](#7605) fix(desktop): drop duplicate create-workspace submits while one is in flight: Reliability or visual fix restores expected behavior; no new workflow or necessary workaround to document.
- [#7603](#7603) fix(desktop): preserve translation context for route errors: Reliability or visual fix restores expected behavior; no new workflow or necessary workaround to document.
- [#7601](#7601) feat(mobile): let the workspace list scroll under a transparent header: Reliability or visual fix restores expected behavior; no new workflow or necessary workaround to document.
- [#7598](#7598) fix(desktop): keep viewport emulation on a crashed browser pane from crashing the app: Reliability or visual fix restores expected behavior; no new workflow or necessary workaround to document.
- [#7597](#7597) fix(host-service): pin git's diff prefixes so the Changes pane can parse every patch: Reliability or visual fix restores expected behavior; no new workflow or necessary workaround to document.
- [#7593](#7593) fix(api): post the Slack agent's reply after its run budget is spent: Reliability or visual fix restores expected behavior; no new workflow or necessary workaround to document.
- [#7587](#7587) fix(desktop): keep new sidebar group orders on the integer lane: Reliability or visual fix restores expected behavior; no new workflow or necessary workaround to document.
- [#7582](#7582) fix(api): bound every Slack agent call by the run budget: Reliability or visual fix restores expected behavior; no new workflow or necessary workaround to document.
- [#7581](#7581) feat(api): Slack agent foundation — shared handler, execution guard, thread window, model and output fixes: Reliability or visual fix restores expected behavior; no new workflow or necessary workaround to document.
- [#7573](#7573) feat(pages): publish without a workspace: Standalone publishing is already documented in pages.mdx; preserved that guidance and included its contract in the new CLI/MCP reference.
- [#7255](#7255) fix(host-service): preserve consumed Claude prompts in handoffs: Reliability or visual fix restores expected behavior; no new workflow or necessary workaround to document.

## Validation

- bun install: passed; no tracked dependency changes.
- bun run lint:fix: passed, no code fixes.
- bun run lint: passed.
- bun run --cwd apps/docs typecheck: passed.
- Vale on all 16 changed docs: zero errors and warnings. Small pre-existing prose violations in touched pages were corrected to satisfy the SOP.
- git diff --check: passed.

Only apps/docs/content/docs/ and the required append-only root TODO log are included. No push or PR.

37 PRs drove changes; 66 were deliberately skipped as separate documentation work.

* docs: correct stale claims and consolidate weekly updates

Replace outdated remote-port and privacy claims, correct the 90-day leaderboard backfill cap and link settings location, and describe credential use and comment-watch registration accurately. Consolidate iPhone requirements and troubleshooting, trim repeated Pages prose, and keep launch effort details in the CLI reference.

Remove the #7764 startup entry because it does not identify a fixed release and its upgrade instructions are too vague. This supersedes that item in the original PR audit. Validate with docs typecheck, lint:fix, lint, Vale (zero errors or warnings), and git diff --check.

* docs: trim repeated explanations across user guides

* docs: clarify iPhone cloud workspace requirements
@superset-home superset-home mentioned this pull request Oct 27, 2026
Merged

This branch was previously deployed

1 inactive deployment
preview — acb4655d Deployed Sep 20, 2026 by saddlepaddle via Deploy Admin #10108
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@saddlepaddle