Visitar URL original
fix(cli): require daemon mode for automatic host updates by Kitenite · Pull Request #7952 · ParadevAI/Paradev · GitHub
Skip to content

fix(cli): require daemon mode for automatic host updates - #7952

Merged
Kitenite merged 1 commit into
mainfrom
review-merge-decision-ac2b4a1c
Sep 30, 2026
Merged

Kitenite merged 1 commit into
mainfrom
review-merge-decision-ac2b4a1c

Conversation

@Kitenite

@Kitenite Kitenite commented Sep 30, 2026 •

Copy link
Copy Markdown
Member

What & why

Follow-up to #7735. superset start --auto-update previously accepted foreground mode, whose launcher watches the original host process. A successful update replaces that process and causes the launcher to report an unexpected exit; a slow restart can also let the foreground health watchdog kill the updater before rollback completes.

Require --daemon when --auto-update is enabled, rejecting invalid combinations before organization lookup or host startup. The error points to superset start --daemon --auto-update. Update flag help and host-update documentation, and cover omitted/false daemon flags plus valid combinations with regression tests.

How I tested it

  • 11 focused start-command and host-spawn tests passed.
  • CLI package typecheck passed.
  • Repository lint, bun run check:i18n, bun run check:plugins, and git diff --check passed.
  • Full repository typecheck passed (42 tasks).
  • Full repository tests failed outside the changed files: desktop reported 34 failures in Git/worktree and shell-environment tests; host-service integration tests also reported failures (including session-folder name deduplication). These failures were not investigated or established as pre-existing in this PR.
  • No live update/restart was performed; tests exercise command validation and host spawn wiring.

Checklist

  • PR title follows conventional commits (type(scope): subject)
  • bun run lint and bun run typecheck pass (CI fails on lint warnings too)
  • "Allow edits from maintainers" is checked on fork PRs (same-repository branch)

Summary by CodeRabbit

  • New Features
    • The --auto-update option now requires --daemon, with guidance shown if used without it.
  • Documentation
    • Clarified that automatic updates restart the host hourly and documented how foreground monitoring may misreport or interrupt a slow updater restart.

@coderabbitai

coderabbitai Bot commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 5f47d27f-6017-467f-a0cc-68cf64b2dea5

📥 Commits

Reviewing files that changed from the base of the PR and between 5457227 and bfb6dbb.

📒 Files selected for processing (3)
  • docs/host-updates.md
  • packages/cli/src/commands/start/command.test.ts
  • packages/cli/src/commands/start/command.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.


📝 Walkthrough

Walkthrough

The start command now rejects --auto-update unless --daemon is enabled. Tests cover this validation and allowed option combinations. The host update documentation describes the foreground restart behavior.

Changes

Automatic updates in daemon mode

Layer / File(s) Summary
Validate automatic update options
packages/cli/src/commands/start/command.ts, packages/cli/src/commands/start/command.test.ts, docs/host-updates.md
The command reports an error when --auto-update is enabled without --daemon. Tests check rejection before organization lookup and cover allowed option combinations. The documentation describes how foreground monitoring handles host replacement and slow restarts.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to bfb6d

The start command now requires --daemon when --auto-update is used, and the error message points to the correct invocation. The docs describe the reason. No merge-blocking risk was found.

Architecture Summary

Architecture risk: 🔵 Low · up to bfb6d

The change affects 2 systems.

Changed systems: packages/cli, docs

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — packages/cli (library) was modified; 2 changed files map to changed impact.
  • observed — docs (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in docs/host-updates.md: Added an explanation that automatic updates require daemon mode because the foreground launcher treats replacement of the host process as failure and its health watchdog may terminate the updater during a slow restart.
  • observed — Modified behavior in packages/cli/src/commands/start/command.test.ts: Adds tests for startCommand.run covering rejection before organization lookup for auto-update without daemon, and lookup invocation and error propagation for three allowed option combinations.
  • observed — Modified behavior in packages/cli/src/commands/start/command.ts: The --auto-update description now specifies its hourly restart behavior and daemon requirement. The command rejects --auto-update when --daemon is false, with an error message and suggested invocation.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title uses conventional commit format and clearly states the main change: automatic host updates now require daemon mode.
Description check ✅ Passed The description includes the required What & why, How I tested it, and Checklist sections. It explains the problem and solution, lists validation steps, and transparently reports unrelated full-test f…
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Kitenite
Kitenite merged commit f8ca1ba into main Sep 30, 2026
19 checks passed
@github-actions

github-actions Bot commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

🚀 Preview Deployment

🔗 Preview Links

Service Status Link
Neon Database (Neon) ✅ View Branch
Vercel API (Vercel) ✅ Open Preview
Vercel Web (Vercel) ✅ Open Preview
Vercel Marketing (Vercel) ✅ Open Preview
Vercel Admin (Vercel) ✅ Open Preview
Vercel Docs (Vercel) ✅ Open Preview

Preview updates automatically with new commits

Kitenite added a commit that referenced this pull request Oct 1, 2026
* docs: weekly update for PRs merged 2026-09-23 to 2026-09-30

Source of truth: live Notion SOP "Weekly Docs Update (automation SOP)".
Window: merged:>=2026-09-23 (139 PRs). PRs through the morning of 09-23
were covered by #7771.

Changes
- Pages: no auto-open on publish (#7790); page links and URL links split
  into their own settings (#7916, #7962, #7946); Listening agents menu with
  per-row stop and Add listening agent (#7724, #7820, #7919); globe on the
  Share button (#7766); Report on public pages (#7886); agents offer a page
  (#7759). Files: pages.mdx, cli/cli-reference.mdx.
- Settings moves: Links replaced by Browser and Files & Editor (#7916,
  #7962). Files: editor.mdx, terminal-integration.mdx, customization.mdx.
- Editor: inline rename and drag to move (#7692), Auto Save (#7693, #7916),
  open and save files outside the workspace (#7897, #7982), Copy as Markdown
  (#7591), per-pane error screen (#7983). File: editor.mdx.
- Terminal copy follows Ghostty's whitespace rules (#7868).
  File: terminal-integration.mdx.
- Agents: UFO (#7898); GPT-6 Astra, Sonnet 5.5, retiring GPT-5.5, retired
  GPT-5.4/5.3 Codex (#7783, #7894, #7935). Files: agent-integration.mdx,
  cli/cli-reference.mdx.
- Host: superset start --daemon --auto-update and update-lock permission
  errors (#7735, #7952). Files: cli/host-server.mdx, cli/cli-reference.mdx.
- Removed the mcp CLI section and the Connected Service Plugins section:
  #7776 made plugins/mcp internal, the Plugins page is staff-flagged, and
  apps/docs/AGENTS.md keeps internal commands out. Files: skills.mdx,
  cli/cli-reference.mdx.
- Slack page unfurls and details panel (#7817, #7821, #7914, #7957).
  File: use-with-slack.mdx.
- Workspaces: instant creation with background naming (#7518); recoverable
  project deletion (#7896). File: workspaces.mdx.
- Shortcuts: prev/next workspace includes Pinned and wraps (#7851); ⌘B
  collapses the sidebar to a rail (#7964). File: keyboard-shortcuts.mdx.
- Ship controls and open-in button moved to the right sidebar strip (#7958).
  Files: diff-viewer.mdx, use-with-ide.mdx.

Deliberately skipped
- Cloud workspaces/environments/sandboxes (flag-gated, AGENTS.md rule):
  #7784 #7795 #7824 #7840 #7844 #7845 #7847 #7849 #7850 #7858 #7861 #7863
  #7874 #7911 #7913 #7918 #7922 #7931 #7932 #7937 #7956 #7961 #7969 #7981
  #7637 #7794 #7789 #7838 (its CLI docs already shipped in the PR).
- Staff-only plugins: #7912 Sentry plugin, #7716, #7727, #7955.
- Already documented in their own PRs: #7917, #7921.
- Removed feature never documented: #7796 Google Calendar triggers.
- Agents chip remove/revert/default-off, never documented: #7870 #7871 #7872.
- Billing/backend policy with no docs surface: #7947, #7812, #7786, #7792,
  #7798, #7761, #7948, #7949, #7951, #7827.
- Reverted security trio: #7828 #7829 #7830 (reverted by #7834).
- Fixes restoring expected behavior: #7683 #7696 #7707 #7743 #7751 #7756
  #7764 #7765 #7781 #7788 #7791 #7823 #7825 #7833 #7837 #7852 #7857 #7860
  #7864 #7865 #7869 #7873 #7897-covered #7903 #7938 #7980 #7943 #7964-chrome.
- Mobile (no docs page): #7746 #7747 #7748 #7749 #7750 #7782 #7793 #7810
  #7814 #7816 #7889 #7968.
- Marketing, internal docs, CI, version bumps: #7651 #7744 #7752 #7771 #7774
  #7776-infra #7777 #7785 #7811 #7818 #7822 #7826 #7834 #7884 #7885 #7895
  #7909 #7933 #7934 #7942 #7944 #7965 #7966.

Validation: bun run --cwd apps/docs typecheck, bun run lint:fix,
bun run lint (exit 0), Vale on 13 changed files (0 errors, 0 warnings),
git diff --check.

* chore: log weekly docs update follow-ups

* docs: tighten review findings in the weekly update

Only the page creator can stop or add listening agents. On focus change also
saves on window blur, and Auto Save pauses on conflicts. Taken-down pages do
not unfurl. Model picker coverage matches agent-models.ts.

This branch was previously deployed

1 inactive deployment
preview — bfb6dbbf Deployed Sep 30, 2026 by Kitenite via Deploy Admin #10584
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant