Visitar URL original
Fix assertions in tests that were always `True` by namurphy · Pull Request #1634 · PlasmaPy/PlasmaPy · GitHub
Skip to content

Fix assertions in tests that were always True #1634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
namurphy merged 1 commit into from
Jul 16, 2022
Merged

Fix assertions in tests that were always True #1634

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions plasmapy/formulary/tests/test_dielectric.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,8 +172,7 @@ def test_known(self, kwargs, expected):
kwargs["kWave"] = kwargs["omega"] / vth

val = permittivity_1D_Maxwellian(**kwargs)
assert (
np.isclose(val, expected, rtol=1e-6, atol=0.0),
assert np.isclose(val, expected, rtol=1e-6, atol=0.0), (
f"Permittivity value should be {expected} and not {val}.",
)

Expand All @@ -189,8 +188,7 @@ def test_fail(self, kwargs, expected):
val = permittivity_1D_Maxwellian(**kwargs)

expected += 1e-15
assert (
not np.isclose(val, expected, rtol=1e-16, atol=0.0),
assert not np.isclose(val, expected, rtol=1e-16, atol=0.0), (
f"Permittivity value test gives {val} and should not be "
f"equal to {expected}.",
)
Expand Down Expand Up @@ -218,8 +216,7 @@ def test_normal_vs_lite_values(self, kwargs, expected):
wp.value,
)

assert (
np.isclose(val, val_lite, rtol=1e-6, atol=0.0),
assert np.isclose(val, val_lite, rtol=1e-6, atol=0.0), (
"'permittivity_1D_Maxwellian' and 'permittivity_1D_Maxwellian_lite' "
"do not agree.",
)