Repository navigation
Move & revise section on installing and using pre-commit - #1651
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1651 +/- ##
=======================================
Coverage 97.21% 97.21%
=======================================
Files 83 83
Lines 7962 7962
=======================================
Hits 7740 7740
Misses 222 222 Continue to review full report at Codecov.
|
StanczakDominik
previously approved these changes
Jul 29, 2022
StanczakDominik
left a comment
Member
There was a problem hiding this comment.
Good rewrite, looks great, conditional on the two minor missing links in the doc tests finding themselves, of course ;)
Comment on lines
+236
to
+237
| that says ``pre-commit.ci autofix``. After doing this, be sure to `pull | ||
| the changes`_ from GitHub to your computer with ``git pull``. |
Member
There was a problem hiding this comment.
Missing a link, I suspect external?
| * ``trailing-whitespace`` to remove trailing whitespace. | ||
| * black_ to format code. | ||
| * isort_ to sort imports. | ||
| * nbqa_ to format notebooks. |
Member
There was a problem hiding this comment.
I guess we'd need https://github.com/nbQA-dev/nbQA in the common_links section for this to work!
rocco8773
approved these changes
Aug 2, 2022
This was referenced Aug 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #1305, I updated the section that describes how to use pre-commit in the coding guide. This PR takes that section and moves it to
install_dev.rst, which I'm intending to update later.I still have to...