Visitar URL original
added importlib.metdata in plasmapy/__init__.py by MKastek · Pull Request #1692 · PlasmaPy/PlasmaPy · GitHub
Skip to content

added importlib.metdata in plasmapy/__init__.py - #1692

Merged
StanczakDominik merged 3 commits into
PlasmaPy:mainfrom
MKastek:use_importlib.metadata_instead_of_pkg_resources
Aug 25, 2022
Merged

added importlib.metdata in plasmapy/__init__.py#1692
StanczakDominik merged 3 commits into
PlasmaPy:mainfrom
MKastek:use_importlib.metadata_instead_of_pkg_resources

Conversation

@MKastek

@MKastek MKastek commented Aug 25, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • I have added a changelog entry for this pull request.
  • If adding new functionality, I have added tests and
    docstrings.
  • I have fixed any newly failing tests.

Closes #1620

@MKastek

MKastek commented Aug 25, 2022

Copy link
Copy Markdown
Contributor Author

pre-commit.ci autofix

@codecov

codecov Bot commented Aug 25, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1692 (dc00f88) into main (9ef6671) will not change coverage.
The diff coverage is 75.00%.

@@           Coverage Diff           @@
##             main    #1692   +/-   ##
=======================================
  Coverage   97.63%   97.63%           
=======================================
  Files          85       85           
  Lines        8020     8020           
=======================================
  Hits         7830     7830           
  Misses        190      190
Impacted Files Coverage Δ
plasmapy/__init__.py 33.33% <75.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@StanczakDominik

StanczakDominik commented Aug 25, 2022

Copy link
Copy Markdown
Member

With this version installed:

>>> plasmapy.__version__
'0.8.2.dev51+gdc00f885'

With the previous:

>>> plasmapy.__version__
'0.8.2.dev48+g9ef66715'

So that looks nice and compatible. 👍🏻 Let's get it in! Thanks!

@StanczakDominik
StanczakDominik merged commit f3f76ef into PlasmaPy:main Aug 25, 2022
@MKastek
MKastek deleted the use_importlib.metadata_instead_of_pkg_resources branch August 25, 2022 15:19
namurphy added a commit to namurphy/PlasmaPy that referenced this pull request Oct 25, 2022
@namurphy
Revise changelog for PlasmaPy#1692
b9b2e9c
@namurphy namurphy added the packaging Related to packaging or distribution label May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StanczakDominik StanczakDominik StanczakDominik approved these changes

Assignees

No one assigned

Labels

packaging Related to packaging or distribution

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Use importlib.metadata to get package version instead of pkg_resources

3 participants

@MKastek @StanczakDominik @namurphy