Visitar URL original
Fix documentation build errors by JaydenR2305 · Pull Request #1710 · PlasmaPy/PlasmaPy · GitHub
Skip to content

Fix documentation build errors - #1710

Merged
namurphy merged 7 commits into
PlasmaPy:mainfrom
JaydenR2305:fix-documentation-build
Aug 30, 2022
Merged

Fix documentation build errors#1710
namurphy merged 7 commits into
PlasmaPy:mainfrom
JaydenR2305:fix-documentation-build

Conversation

@JaydenR2305

@JaydenR2305 JaydenR2305 commented Aug 30, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

This pull request resolves an error in building documentation that seems to have arisen due to towncrier release 22.8.0.

  • I have added a changelog entry for this pull request.
  • If adding new functionality, I have added tests and
    docstrings.
  • I have fixed any newly failing tests.

@JaydenR2305
JaydenR2305 marked this pull request as draft August 30, 2022 16:07
@github-actions github-actions Bot added the docs PlasmaPy Docs at http://docs.plasmapy.org label Aug 30, 2022
@codecov

codecov Bot commented Aug 30, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1710 (3951c24) into main (33f9230) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1710   +/-   ##
=======================================
  Coverage   97.67%   97.67%           
=======================================
  Files          87       87           
  Lines        8204     8204           
=======================================
  Hits         8013     8013           
  Misses        191      191

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions github-actions Bot removed the docs PlasmaPy Docs at http://docs.plasmapy.org label Aug 30, 2022
@JaydenR2305
JaydenR2305 marked this pull request as ready for review August 30, 2022 16:31
@JaydenR2305

JaydenR2305 commented Aug 30, 2022

Copy link
Copy Markdown
Member Author

@pheuer 🎊

@pheuer

pheuer commented Aug 30, 2022

Copy link
Copy Markdown
Member

see discussion in #1703

namurphy
namurphy reviewed Aug 30, 2022
View reviewed changes

@namurphy namurphy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for tracking down what was causing this so quickly! I added some suggestions to broaden the range of towncrier versions to reduce the chances of a version conflict with the requirements of any other packages. Thank you again!

Comment thread requirements/docs.txt Resolved
Comment thread setup.cfg Resolved
@namurphy namurphy mentioned this pull request Aug 30, 2022
Merged
JaydenR2305 and others added 2 commits August 30, 2022 13:22
@JaydenR2305 @namurphy
Update requirements/docs.txt
0168f17 
Co-authored-by: Nick Murphy <namurphy@cfa.harvard.edu>
@JaydenR2305 @namurphy
Update setup.cfg
3951c24 
Co-authored-by: Nick Murphy <namurphy@cfa.harvard.edu>
@namurphy
namurphy enabled auto-merge (squash) August 30, 2022 17:29
@namurphy namurphy mentioned this pull request Aug 30, 2022
Closed
@namurphy
namurphy merged commit a6e6fc1 into PlasmaPy:main Aug 30, 2022
@JaydenR2305
JaydenR2305 deleted the fix-documentation-build branch August 30, 2022 17:37
This was referenced Aug 31, 2022
Merged
Closed
namurphy added a commit to namurphy/PlasmaPy that referenced this pull request Oct 25, 2022
@namurphy
Revise changelog for PlasmaPy#1710
3f526e5
@namurphy namurphy added the docs PlasmaPy Docs at http://docs.plasmapy.org label May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@namurphy namurphy namurphy approved these changes
@StanczakDominik StanczakDominik Awaiting requested review from StanczakDominik

Assignees

No one assigned

Labels

docs PlasmaPy Docs at http://docs.plasmapy.org

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JaydenR2305 @pheuer @namurphy