Repository navigation
Revert "Limit CODEOWNERS to pinging plasmapy-reviewers group" - #1739
Merged
StanczakDominik merged 1 commit intoSep 13, 2022
Merged
Conversation
This reverts commit 5681a0f.
|
Thank you for contributing to PlasmaPy! The project's future depends deeply on contributors like you, so we deeply appreciate it! 🌱 The following checklist will be used by the code reviewer to help guide the code review process.
|
rocco8773
requested review from
a team and
namurphy
and removed request for
a team and
namurphy
September 13, 2022 18:28
StanczakDominik
approved these changes
Sep 13, 2022
StanczakDominik
enabled auto-merge (squash)
September 13, 2022 18:30
Codecov ReportBase: 98.15% // Head: 98.15% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #1739 +/- ##
=======================================
Coverage 98.15% 98.15%
=======================================
Files 87 87
Lines 8091 8091
=======================================
Hits 7942 7942
Misses 149 149 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
namurphy
deleted the
revert-1351-codeowners_but_its_all_public_property
branch
September 13, 2022 18:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #1351
We decided we like the more granular approach.