Visitar URL original
Delete `codemeta.json` in favor of `CITATION.cff` by namurphy · Pull Request #1772 · PlasmaPy/PlasmaPy · GitHub
Skip to content

Delete codemeta.json in favor of CITATION.cff - #1772

Merged
StanczakDominik merged 8 commits into
PlasmaPy:mainfrom
namurphy:cff-instead-of-codemeta
Oct 31, 2022
Merged

StanczakDominik merged 8 commits into
PlasmaPy:mainfrom
namurphy:cff-instead-of-codemeta

Conversation

@namurphy

Copy link
Copy Markdown
Member

Right now, we use both codemeta.json and CITATION.cff to include metadata for our project. While CodeMeta and Citation File Format each have useful fields that the other one does not have, it'll be a pain to keep both up-to-date...in particular because the bulk of the information (i.e., the author list) will be duplicated in both. Thinking about the tradeoffs between the two of them, CITATION.cff has better integration with GitHub and Zenodo, and thus would end up making our lives easier.

We could eventually go back to codemeta.json, especially since there are tools that will do the conversion from CodeMeta → CFF, though I had trouble finding ones that went CFF → CodeMeta and covered all of the fields that we needed and were out of beta.

(I do really like the CodeMeta format though, but alas!)

@github-actions

Copy link
Copy Markdown

Thank you for contributing to PlasmaPy! The project's future depends deeply on contributors like you, so we deeply appreciate it! 🌱 The following checklist will be used by the code reviewer to help guide the code review process.

  • Overall
    • Does the PR do what it intends to do?
    • Except for very minor changes, is a changelog entry included and consistent with the changelog guide?
    • Are the continuous integration checks passing? (Most linter problems can be automagically fixed by commenting on this PR with pre-commit.ci autofix.)
  • Code
    • Is new/updated code understandable and consistent with the coding guide?
    • Are there ways to greatly simplify the implementation?
    • Are there any large functions that should be split up into shorter functions?
  • Tests
    • Are tests added/updated as required, and consistent with the testing guide?
    • Are the tests understandable?
    • Do the tests cover all important cases?
  • Docs
    • Are docs added/updated as required, and consistent with the doc guide?
    • Are the docs understandable?
    • Do the docs show up correctly in the preview, including Jupyter notebooks?

@codecov

codecov Bot commented Oct 31, 2022 •

Copy link
Copy Markdown

Codecov Report

Base: 98.36% // Head: 98.36% // No change to project coverage 👍

Coverage data is based on head (7a169b0) compared to base (941fcea).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1772   +/-   ##
=======================================
  Coverage   98.36%   98.36%           
=======================================
  Files          86       86           
  Lines        8176     8176           
=======================================
  Hits         8042     8042           
  Misses        134      134           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@namurphy namurphy changed the title Delete codemeta.json Delete codemeta.json in favor of CITATION.cff Oct 31, 2022
@namurphy
namurphy marked this pull request as ready for review October 31, 2022 16:15
@namurphy
namurphy requested a review from a team as a code owner October 31, 2022 16:15
@namurphy
namurphy requested review from StanczakDominik and removed request for a team October 31, 2022 16:15

@StanczakDominik StanczakDominik left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely addition-to-deletion ratio <3

@StanczakDominik
StanczakDominik merged commit b4e4c4a into PlasmaPy:main Oct 31, 2022
@namurphy

Copy link
Copy Markdown
Member Author

If we eventually consider going back to codemeta.json, my current thinking is that the capabilities that should exist in the ecosystem are:

  • Integration of CodeMeta with GitHub
  • Integration of CodeMeta with Zenodo
  • A place to put both the GitHub identifier (alias in CFF) and ORCID (orcid in CFF) in CodeMeta
  • Tools that can convert from CITATION.cff ↔ codemeta.json, not just CITATION.cff → codemeta.json
  • A pre-commit hook or GitHub Action that would validate codemeta.json

We probably shouldn't switch again unless we have a good reason to (e.g., a need for fields in CodeMeta that ∄ in CFF or that CodeMeta becomes much more widely used than CFF).

@namurphy
namurphy deleted the cff-instead-of-codemeta branch October 31, 2022 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants