Repository navigation
Use pretty-format-yaml pre-commit hook on CITATION.cff - #1773
Merged
StanczakDominik merged 2 commits intoOct 31, 2022
Merged
Conversation
|
Thank you for contributing to PlasmaPy! The project's future depends deeply on contributors like you, so we deeply appreciate it! 🌱 The following checklist will be used by the code reviewer to help guide the code review process.
|
Codecov ReportBase: 98.36% // Head: 98.36% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #1773 +/- ##
=======================================
Coverage 98.36% 98.36%
=======================================
Files 86 86
Lines 8176 8176
=======================================
Hits 8042 8042
Misses 134 134 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
namurphy
marked this pull request as ready for review
October 31, 2022 16:14
namurphy
requested review from
StanczakDominik
and removed request for
a team
October 31, 2022 16:14
StanczakDominik
approved these changes
Oct 31, 2022
Member
Author
|
Thank you for the quick reviews! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CITATION.cffis a YAML file, but thepretty-format-yamlpre-commit hook does not get applied to it because it does not have the.ymlor.yamlfile extension. For this PR, I renamedCITATION.cff→CITATION.yaml, ranpre-commit run --all-files, and renamedCITATION.yaml→CITATION.cff. I only made formatting changes to this file.