Visitar URL original
Fix weekly test against development version of NumPy by namurphy · Pull Request #1841 · PlasmaPy/PlasmaPy · GitHub
Skip to content

Fix weekly test against development version of NumPy - #1841

Merged
StanczakDominik merged 6 commits into
PlasmaPy:mainfrom
namurphy:update-numpy-dev-test
Dec 20, 2022
Merged

StanczakDominik merged 6 commits into
PlasmaPy:mainfrom
namurphy:update-numpy-dev-test

Conversation

@namurphy

Copy link
Copy Markdown
Member

The weekly tests have been failing because apparently the NIGHTLY builds of NumPy are no longer pointing to the right place. This PR aims to update the test setup to point it to the right location.

My first try is to point to NumPy's GitHub repository, which would unfortunately mean that it would have to rebuild NumPy (which could be time-consuming and unnecessary). Going with this route would be a temporary fix, and I'd raise another issue to fix that.

@github-actions

Copy link
Copy Markdown

Thank you for contributing to PlasmaPy! The project's future depends deeply on contributors like you, so we deeply appreciate it! 🌱 The following checklist will be used by the code reviewer to help guide the code review process.

  • Overall
    • Does the PR do what it intends to do?
    • Except for very minor changes, is a changelog entry included and consistent with the changelog guide?
    • Are the continuous integration checks passing? (Most linter problems can be automagically fixed by commenting on this PR with pre-commit.ci autofix.)
  • Code
    • Is new/updated code understandable and consistent with the coding guide?
    • Are there ways to greatly simplify the implementation?
    • Are there any large functions that should be split up into shorter functions?
  • Tests
    • Are tests added/updated as required, and consistent with the testing guide?
    • Are the tests understandable?
    • Do the tests cover all important cases?
  • Docs
    • Are docs added/updated as required, and consistent with the doc guide?
    • Are the docs understandable?
    • Do the docs show up correctly in the preview, including Jupyter notebooks?

@namurphy namurphy added the no changelog entry needed For PRs that should not have a changelog entry label Dec 20, 2022
@codecov

codecov Bot commented Dec 20, 2022 •

Copy link
Copy Markdown

Codecov Report

Base: 98.33% // Head: 98.33% // No change to project coverage 👍

Coverage data is based on head (fd5ed70) compared to base (fedcdad).
Patch has no changes to coverable lines.

❗ Current head fd5ed70 differs from pull request most recent head e18507b. Consider uploading reports for the commit e18507b to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1841   +/-   ##
=======================================
  Coverage   98.33%   98.33%           
=======================================
  Files          95       95           
  Lines        8343     8343           
=======================================
  Hits         8204     8204           
  Misses        139      139           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@namurphy
namurphy marked this pull request as ready for review December 20, 2022 19:35
@namurphy
namurphy requested a review from a team as a code owner December 20, 2022 19:35
@StanczakDominik
StanczakDominik enabled auto-merge (squash) December 20, 2022 19:47
@StanczakDominik
StanczakDominik merged commit 5eda6f1 into PlasmaPy:main Dec 20, 2022
@namurphy
namurphy deleted the update-numpy-dev-test branch December 21, 2022 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no changelog entry needed For PRs that should not have a changelog entry testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants