Visitar URL original
Drop `dev` dependencies from pyproject.toml by StanczakDominik · Pull Request #1843 · PlasmaPy/PlasmaPy · GitHub
Skip to content

Drop dev dependencies from pyproject.toml - #1843

Merged
StanczakDominik merged 7 commits into
PlasmaPy:mainfrom
StanczakDominik:dry-dependencies
Dec 25, 2022
Merged

StanczakDominik merged 7 commits into
PlasmaPy:mainfrom
StanczakDominik:dry-dependencies

Conversation

@StanczakDominik

@StanczakDominik StanczakDominik commented Dec 20, 2022 •

Copy link
Copy Markdown
Member
  • update docs (rg --type rst dev)

@github-actions

Copy link
Copy Markdown

Thank you for contributing to PlasmaPy! The project's future depends deeply on contributors like you, so we deeply appreciate it! 🌱 The following checklist will be used by the code reviewer to help guide the code review process.

  • Overall
    • Does the PR do what it intends to do?
    • Except for very minor changes, is a changelog entry included and consistent with the changelog guide?
    • Are the continuous integration checks passing? (Most linter problems can be automagically fixed by commenting on this PR with pre-commit.ci autofix.)
  • Code
    • Is new/updated code understandable and consistent with the coding guide?
    • Are there ways to greatly simplify the implementation?
    • Are there any large functions that should be split up into shorter functions?
  • Tests
    • Are tests added/updated as required, and consistent with the testing guide?
    • Are the tests understandable?
    • Do the tests cover all important cases?
  • Docs
    • Are docs added/updated as required, and consistent with the doc guide?
    • Are the docs understandable?
    • Do the docs show up correctly in the preview, including Jupyter notebooks?

@codecov

codecov Bot commented Dec 20, 2022 •

Copy link
Copy Markdown

Codecov Report

Base: 98.33% // Head: 98.31% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (71c4214) compared to base (5eda6f1).
Patch coverage: 99.43% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1843      +/-   ##
==========================================
- Coverage   98.33%   98.31%   -0.02%     
==========================================
  Files          95       95              
  Lines        8343     8372      +29     
==========================================
+ Hits         8204     8231      +27     
- Misses        139      141       +2     
Impacted Files Coverage Δ
plasmapy/formulary/quantum.py 100.00% <ø> (ø)
plasmapy/formulary/relativity.py 99.21% <ø> (ø)
plasmapy/particles/atomic.py 98.64% <ø> (ø)
plasmapy/particles/ionization_state.py 94.92% <ø> (ø)
...rged_particle_radiography/synthetic_radiography.py 99.75% <98.70%> (-0.25%) ⬇️
plasmapy/analysis/fit_functions.py 100.00% <100.00%> (ø)
plasmapy/analysis/nullpoint.py 98.53% <100.00%> (ø)
...mapy/analysis/swept_langmuir/floating_potential.py 100.00% <100.00%> (ø)
.../analysis/swept_langmuir/ion_saturation_current.py 100.00% <100.00%> (ø)
plasmapy/diagnostics/langmuir.py 93.69% <100.00%> (+0.05%) ⬆️
... and 23 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@StanczakDominik StanczakDominik added the no changelog entry needed For PRs that should not have a changelog entry label Dec 24, 2022
@StanczakDominik
StanczakDominik marked this pull request as ready for review December 24, 2022 10:13
@StanczakDominik
StanczakDominik requested a review from a team as a code owner December 24, 2022 10:13
@StanczakDominik
StanczakDominik requested review from namurphy and removed request for a team December 24, 2022 10:13
@StanczakDominik

Copy link
Copy Markdown
Member Author

I removed a bunch of additional, duplicated cruft from the docs. I honestly have never seen a situation in which pip install . couldn't also be accompanied by --editable.

@namurphy namurphy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! A few minor possible suggestions. Thank you!

Comment thread docs/contributing/install_dev.rst Resolved
Comment thread docs/contributing/install_dev.rst Resolved
Comment thread docs/contributing/install_dev.rst Resolved
Co-authored-by: Nick Murphy <namurphy@cfa.harvard.edu>
@StanczakDominik
StanczakDominik enabled auto-merge (squash) December 25, 2022 07:56
@StanczakDominik
StanczakDominik merged commit 034f764 into PlasmaPy:main Dec 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no changelog entry needed For PRs that should not have a changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants