Visitar URL original
Revert updates to GitHub Action by namurphy · Pull Request #1859 · PlasmaPy/PlasmaPy · GitHub
Skip to content

Revert updates to GitHub Action - #1859

Merged
StanczakDominik merged 6 commits into
PlasmaPy:mainfrom
namurphy:revert-github-action-updates
Dec 24, 2022
Merged

StanczakDominik merged 6 commits into
PlasmaPy:mainfrom
namurphy:revert-github-action-updates

Conversation

@namurphy

@namurphy namurphy commented Dec 24, 2022 •

Copy link
Copy Markdown
Member

This PR reverts #1857, #1855, and #1852 to go back to...I hope...the last commit where the GitHub Action to post the code review checklist was actually working. This has been an adventure (sigh).

I'm temporarily changing pull_request_target to pull_request, which after reading the docs, I think will let me test this GA while it's still in the PR stage.

Update: ↑ doesn't actually let me check the action, since it requires permissions (sigh).

@namurphy namurphy added the no changelog entry needed For PRs that should not have a changelog entry label Dec 24, 2022
@namurphy
namurphy marked this pull request as ready for review December 24, 2022 01:00
@namurphy
namurphy requested a review from a team as a code owner December 24, 2022 01:00
@namurphy
namurphy requested review from StanczakDominik and removed request for a team December 24, 2022 01:00
@codecov

codecov Bot commented Dec 24, 2022 •

Copy link
Copy Markdown

Codecov Report

Base: 98.31% // Head: 98.31% // No change to project coverage 👍

Coverage data is based on head (52c6443) compared to base (29ae366).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1859   +/-   ##
=======================================
  Coverage   98.31%   98.31%           
=======================================
  Files          95       95           
  Lines        8372     8372           
=======================================
  Hits         8231     8231           
  Misses        141      141           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@StanczakDominik
StanczakDominik merged commit 4bdd331 into PlasmaPy:main Dec 24, 2022
@namurphy namurphy added the GitHub Actions A continuous integration platform for automating tests and other tasks (see .github/ directory) label May 23, 2023
@namurphy
namurphy deleted the revert-github-action-updates branch May 24, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

GitHub Actions A continuous integration platform for automating tests and other tasks (see .github/ directory) no changelog entry needed For PRs that should not have a changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants