Visitar URL original
[pre-commit.ci] pre-commit autoupdate by pre-commit-ci[bot] · Pull Request #1863 · PlasmaPy/PlasmaPy · GitHub
Skip to content

[pre-commit.ci] pre-commit autoupdate - #1863

Merged
namurphy merged 4 commits into
mainfrom
pre-commit-ci-update-config
Jan 10, 2023
Merged

namurphy merged 4 commits into
mainfrom
pre-commit-ci-update-config

Conversation

updates:
- [github.com/pre-commit/pre-commit-hooks: v4.3.0 → v4.4.0](pre-commit/pre-commit-hooks@v4.3.0...v4.4.0)
- [github.com/macisamuele/language-formatters-pre-commit-hooks: v2.4.0 → v2.5.0](macisamuele/language-formatters-pre-commit-hooks@v2.4.0...v2.5.0)
- [github.com/asottile/pyupgrade: v3.2.2 → v3.3.1](asottile/pyupgrade@v3.2.2...v3.3.1)
- [github.com/charliermarsh/ruff-pre-commit: v0.0.192 → v0.0.206](astral-sh/ruff-pre-commit@v0.0.192...v0.0.206)
- [github.com/PyCQA/isort: 5.10.1 → 5.11.4](PyCQA/isort@5.10.1...5.11.4)
- [github.com/psf/black: 22.10.0 → 22.12.0](psf/black@22.10.0...22.12.0)
- [github.com/nbQA-dev/nbQA: 1.5.3 → 1.6.0](nbQA-dev/nbQA@1.5.3...1.6.0)
@pre-commit-ci
pre-commit-ci Bot requested a review from a team as a code owner January 2, 2023 20:32
@pre-commit-ci
pre-commit-ci Bot requested review from namurphy and removed request for a team January 2, 2023 20:32
@pre-commit-ci
pre-commit-ci Bot force-pushed the pre-commit-ci-update-config branch from ba75c73 to 9bac1a1 Compare January 2, 2023 20:32
@github-actions

github-actions Bot commented Jan 2, 2023

Copy link
Copy Markdown

Thank you for contributing to PlasmaPy! The project's future depends deeply on contributors like you, so we deeply appreciate it! 🌱 The following checklist will be used by the code reviewer to help guide the code review process.

  • Overall
    • Does the PR do what it intends to do?
    • Except for very minor changes, is a changelog entry included and consistent with the changelog guide?
    • Are the continuous integration checks passing? (Most linter problems can be automagically fixed by commenting on this PR with pre-commit.ci autofix.)
  • Code
    • Is new/updated code understandable and consistent with the coding guide?
    • Are there ways to greatly simplify the implementation?
    • Are there any large functions that should be split up into shorter functions?
  • Tests
    • Are tests added/updated as required, and consistent with the testing guide?
    • Are the tests understandable?
    • Do the tests cover all important cases?
  • Docs
    • Are docs added/updated as required, and consistent with the doc guide?
    • Are the docs understandable?
    • Do the docs show up correctly in the preview, including Jupyter notebooks?

@codecov

codecov Bot commented Jan 2, 2023 •

Copy link
Copy Markdown

Codecov Report

Base: 98.31% // Head: 98.31% // No change to project coverage 👍

Coverage data is based on head (669bdf8) compared to base (a970130).
Patch has no changes to coverable lines.

❗ Current head 669bdf8 differs from pull request most recent head bb01910. Consider uploading reports for the commit bb01910 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1863   +/-   ##
=======================================
  Coverage   98.31%   98.31%           
=======================================
  Files          95       95           
  Lines        8372     8372           
=======================================
  Hits         8231     8231           
  Misses        141      141           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@StanczakDominik

Copy link
Copy Markdown
Member

pre-commit.ci autofix

@StanczakDominik StanczakDominik added the no changelog entry needed For PRs that should not have a changelog entry label Jan 3, 2023
Comment thread .pre-commit-config.yaml Resolved
@namurphy

namurphy commented Jan 3, 2023

Copy link
Copy Markdown
Member

The pre-commit failure appears to be upstream of pretty-format-toml, but there's an issue for it and it looks like it's being worked on. It requires This seems to be one of those errors that'll get fixed if we don't do anything (thank you upstream maintainers!), so my inclination is to wait to do anything unless it starts to hold up PRs, in which case we can temporarily turn off pretty-format-toml.

@namurphy
namurphy enabled auto-merge (squash) January 10, 2023 00:27
@namurphy
namurphy merged commit 0be9428 into main Jan 10, 2023
@StanczakDominik
StanczakDominik deleted the pre-commit-ci-update-config branch January 18, 2023 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no changelog entry needed For PRs that should not have a changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants