Visitar URL original
Avoid extra SMB queries when formatting file names by daxian-dbw · Pull Request #28038 · PowerShell/PowerShell · GitHub
Skip to content

Avoid extra SMB queries when formatting file names #28038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Dongbo Wang (daxian-dbw) merged 1 commit into from
Oct 9, 2026
Merged

Avoid extra SMB queries when formatting file names #28038

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/System.Management.Automation/namespaces/FileSystemProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1953,7 +1953,10 @@ public static string NameString(PSObject instance)
{
if (instance?.BaseObject is FileSystemInfo fileInfo)
{
if (InternalSymbolicLinkLinkCodeMethods.IsReparsePointLikeSymlink(fileInfo))
// Checking the cached attributes first avoids an extra filesystem query for every non-link,
// which is particularly expensive when formatting items on an SMB share.
if (InternalSymbolicLinkLinkCodeMethods.IsReparsePoint(fileInfo)
&& InternalSymbolicLinkLinkCodeMethods.IsReparsePointLikeSymlink(fileInfo))

@iSazonov Ilya (iSazonov) Oct 9, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The IsReparsePointLikeSymlink method is used in RemoveDirectoryInfoItem(), so I guess it makes sense to insert this check there too.

@daxian-dbw Dongbo Wang (daxian-dbw) Oct 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's out of scope for this PR. This PR is only for fixing the formatting.

{
return $"{PSStyle.Instance.FileInfo.SymbolicLink}{fileInfo.Name}{PSStyle.Instance.Reset} -> {fileInfo.LinkTarget}";
}
Expand Down
12 changes: 12 additions & 0 deletions test/powershell/Modules/Microsoft.PowerShell.Management/Get-Item.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,18 @@ Describe 'Formatting for FileInfo objects' -Tags 'CI' {
$dir.NameString | Should -BeExactly "$($PSStyle.FileInfo.Directory + $dir.Name + $PSStyle.Reset)"
}

It 'NameString should not query link metadata for a cached non-reparse point' -Skip:(-not $IsWindows) {
$testFile = Join-Path -Path $TestDrive -ChildPath 'cached-metadata'
$file = New-Item -ItemType File -Path $testFile
$null = $file.Attributes

# Removing the file makes an unnecessary second filesystem query observable.
[System.IO.File]::Delete($testFile)

# Without the cached-attributes check, NameString queries the deleted path for link metadata and throws.
[Microsoft.PowerShell.Commands.FileSystemProvider]::NameString($file) | Should -BeExactly $file.Name
}

It 'Executable should have correct color' {
if ($IsWindows) {
$exePath = Join-Path -Path $TestDrive -ChildPath 'myExe.exe'
Expand Down
Loading