Visitar URL original
Add QUERY method support for Invoke-WebRequest by soroshsabz · Pull Request #28110 · PowerShell/PowerShell · GitHub
Skip to content

Add QUERY method support for Invoke-WebRequest - #28110

Open
soroshsabz wants to merge 5 commits into
PowerShell:masterfrom
soroshsabz:features/1-query-method
Open

Add QUERY method support for Invoke-WebRequest#28110
soroshsabz wants to merge 5 commits into
PowerShell:masterfrom
soroshsabz:features/1-query-method

Conversation

@soroshsabz

@soroshsabz soroshsabz commented Sep 25, 2026 •
edited
Loading

Copy link
Copy Markdown

ITNOA

PR Summary

Add QUERY method support for Invoke-RestMethod or Invoke-WebRequest.

PR Context

This PR fixes #28061

PR Checklist

@azure-pipelines

azure-pipelines Bot commented Sep 25, 2026

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

@soroshsabz soroshsabz changed the title Add QUERY method support for Invoke-WebRequest WIP: Add QUERY method support for Invoke-WebRequest Sep 25, 2026
@soroshsabz soroshsabz changed the title WIP: Add QUERY method support for Invoke-WebRequest Add QUERY method support for Invoke-WebRequest Sep 25, 2026
@soroshsabz
soroshsabz marked this pull request as ready for review September 25, 2026 22:14
Copilot AI lite review requested due to automatic review settings September 25, 2026 22:14
Copilot AI reviewed Sep 25, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

Implementation and test coverage are complete; only a minor documentation follow-up was noted.

Review effort: Lite
Findings: None

What changed in this PR

Adds first-class QUERY method support to PowerShell web cmdlets with integration tests.

Changes:

  • Adds WebRequestMethod.Query.
  • Maps it to .NET HttpMethod.Query.
  • Adds WebListener routes and cmdlet tests.
File Description
test/​tools/​WebListener/​Startup.cs Adds a QUERY test route.
test/​powershell/​Modules/​Microsoft.PowerShell.Utility/​WebCmdlets.Tests.ps1 Tests QUERY behavior and request bodies.
src/​Microsoft.PowerShell.Commands.Utility/​commands/​utility/​WebCmdlet/​WebRequestMethod.cs Adds the Query enum value.
src/​Microsoft.PowerShell.Commands.Utility/​commands/​utility/​WebCmdlet/​Common/​WebRequestPSCmdlet.Common.cs Maps Query to HttpMethod.Query.

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

@soroshsabz soroshsabz mentioned this pull request Sep 25, 2026
Open
2 tasks done
@daxian-dbw Dongbo Wang (daxian-dbw) added WG-Cmdlets general cmdlet issues CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log WG-NeedsReview Needs a review by the labeled Working Group labels Sep 28, 2026
@daxian-dbw

Dongbo Wang (daxian-dbw) commented Sep 28, 2026

Copy link
Copy Markdown
Member

A note to Cmdlet WG for review: PowerShell already supports sending Query, just not through the enum-backed -Method parameter: Invoke-WebRequest -Uri $uri -CustomMethod QUERY -Body $body.

The enum-backed methods are a curated list of methods. It contains Merge, which is not exposed by a convenient property from System.Net.Http.HttpMethod. HttpMethod exposes 2 convenient properties Connect and Query that are not included in the PowerShell enum. The WG needs to consider if we want to include Connect and Query for -Method, or the existing -CustomMethod is sufficient for them.

@soroshsabz

soroshsabz commented Oct 1, 2026

Copy link
Copy Markdown
Author

Dongbo Wang (@daxian-dbw) what is workflow for review?

@kilasuit

Ryan Yates (kilasuit) commented Oct 2, 2026

Copy link
Copy Markdown
Collaborator

soroshsabz this PR is marked for the Cmdlets Group to review. Please wait for us to get back to you. Also we hadn't yet discussed the issue this PR is to resolve so we have not yet made a recommendation on how or if it needs fixed.

I suggest in future looking for issues that are labeled as up for grabs to implement as opposed to newer issues.

@SteveL-MSFT

Steve Lee (SteveL-MSFT) commented Oct 7, 2026

Copy link
Copy Markdown
Member

The @PowerShell/wg-powershell-cmdlets discussed this. Although -CustomMethod can be used today, we agreed that Query is something that could be more heavily used in the future and makes sense to elevate as a direct method. We don't think Connect fits that criteria today and is something we can always add later should data show that it should be moved up as well.

@SteveL-MSFT Steve Lee (SteveL-MSFT) added WG-Reviewed A Working Group has reviewed this and made a recommendation and removed WG-NeedsReview Needs a review by the labeled Working Group labels Oct 7, 2026
iSazonov
Ilya (iSazonov) reviewed Oct 8, 2026
View reviewed changes
Comment thread ...t.PowerShell.Commands.Utility/commands/utility/WebCmdlet/Common/WebRequestPSCmdlet.Common.cs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@jshigetomi Justin Chung (jshigetomi) Awaiting requested review from jshigetomi jshigetomi is a code owner
@iSazonov Ilya (iSazonov) Awaiting requested review from iSazonov

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log WG-Cmdlets general cmdlet issues WG-Reviewed A Working Group has reviewed this and made a recommendation

Projects

Cmdlets Working Group
Status: Reviewed

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add support for WebRequestMethod QUERY

6 participants

@soroshsabz @daxian-dbw @kilasuit @SteveL-MSFT @iSazonov