Visitar URL original
Build for Alpine arm64 and arm32 by adityapatwardhan · Pull Request #72 · PowerShell/PowerShell-Native · GitHub
Skip to content

Build for Alpine arm64 and arm32 - #72

Open
Aditya Patwardhan (adityapatwardhan) wants to merge 13 commits into
PowerShell:masterfrom
adityapatwardhan:AlpineArm64
Open

Build for Alpine arm64 and arm32#72
Aditya Patwardhan (adityapatwardhan) wants to merge 13 commits into
PowerShell:masterfrom
adityapatwardhan:AlpineArm64

Conversation

@adityapatwardhan

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) commented Aug 30, 2021

Copy link
Copy Markdown
Member

No description provided.

andyleejordan
Andy Jordan (andyleejordan) approved these changes Aug 30, 2021
View reviewed changes

@andyleejordan Andy Jordan (andyleejordan) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) changed the title Build for Alpine arm64 Build for Alpine arm64 and arm32 Sep 1, 2021
andyleejordan
Andy Jordan (andyleejordan) reviewed Sep 2, 2021
View reviewed changes
Comment thread build.psm1 Outdated
andyleejordan
Andy Jordan (andyleejordan) suggested changes Sep 2, 2021
View reviewed changes

@andyleejordan Andy Jordan (andyleejordan) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed some stuff 🤞

Comment thread build.psm1 Outdated
Comment thread build.psm1 Outdated
Comment thread build.psm1 Outdated
Comment thread build.psm1 Outdated
Comment thread build.psm1 Outdated
Comment thread tools/releaseBuild/PowershellNative.ps1 Outdated
Comment thread tools/releaseBuild/build.json
Comment thread tools/releaseBuild/yaml/nuget.yml Outdated
Comment thread tools/releaseBuild/yaml/nuget.yml Outdated
Comment thread tools/releaseBuild/yaml/releaseBuild.yml Outdated
andyleejordan
Andy Jordan (andyleejordan) approved these changes Sep 7, 2021
View reviewed changes

@andyleejordan Andy Jordan (andyleejordan) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but do you want to squash and/or rebase the commits?

@adityapatwardhan

Aditya Patwardhan (adityapatwardhan) commented Sep 7, 2021

Copy link
Copy Markdown
Member Author

Typically we squash.. I am testing that these bits actually work. Also seems the CI does not upload artifacts.. I will work on that now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@andyleejordan Andy Jordan (andyleejordan) andyleejordan approved these changes
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@adityapatwardhan @andyleejordan