Visitar URL original
ci: Migrate remaining GitHub Actions to Hash-pinning by konstin · Pull Request #6471 · PyO3/pyo3 · GitHub
Skip to content

ci: Migrate remaining GitHub Actions to Hash-pinning - #6471

Merged
konstin merged 2 commits into
mainfrom
konsti/pinact-manual
Oct 7, 2026
Merged

ci: Migrate remaining GitHub Actions to Hash-pinning#6471
konstin merged 2 commits into
mainfrom
konsti/pinact-manual

Conversation

@konstin

@konstin konstin commented Sep 29, 2026

Copy link
Copy Markdown
Member

On top of #6470, migrating over the remaining actions. The preinstalled rustup replaces the install action and uv publish avoids using pypa/gh-action-pypi-publish@release/v1.

The CARGO_INCREMENTAL and CARGO_TERM_COLOR values used to be set by the install action.

Base automatically changed from konsti/pinact to main October 6, 2026 06:53
@davidhewitt

davidhewitt commented Oct 7, 2026

Copy link
Copy Markdown
Member

Looks generally good, plz fix merge conflicts

davidhewitt
davidhewitt reviewed Oct 7, 2026
View reviewed changes
Comment thread .github/workflows/benches.yml
Comment on lines +36 to +37
rustup toolchain install stable --profile minimal --no-self-update --component rust-src
rustup default stable

@davidhewitt davidhewitt Oct 7, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think it's worth abstracting some of this into a compound action in .github/actions?

@konstin konstin Oct 7, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so, I'd rather keep it simple.

@konstin
konstin force-pushed the konsti/pinact-manual branch from b1cf62d to ea78b80 Compare October 7, 2026 11:43
@codspeed

codspeed Bot commented Oct 7, 2026 •
edited
Loading

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 143 untouched benchmarks
⏩ 6 skipped benchmarks1

Comparing konsti/pinact-manual (71e30c9) with main (0b3ca65)

Open in CodSpeed

Footnotes

  1. 6 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@davidhewitt

davidhewitt commented Oct 7, 2026

Copy link
Copy Markdown
Member

Just needs merge conflict fixed 👍

konstin added 2 commits October 7, 2026 18:53
@konstin
ci: Migrate remaining GitHub Actions to Hash-pinning
4cf36aa 
On top of #6470, migrating over the remaining actions. The preinstalled `rustup` replaces the install action and `uv publish` avoids using `pypa/gh-action-pypi-publish@release/v1`.

The `CARGO_INCREMENTAL` and `CARGO_TERM_COLOR` values used to be set by the install action.
@konstin
Remove CARGO_INCREMENTAL: 0
71e30c9 
Not necessary anymore, see rust-lang/cargo#17220
@konstin
konstin force-pushed the konsti/pinact-manual branch from 2bc0eeb to 71e30c9 Compare October 7, 2026 17:14
@konstin
konstin enabled auto-merge October 7, 2026 17:15
@konstin
konstin added this pull request to the merge queue Oct 7, 2026
Merged via the queue into main with commit b58de34 Oct 7, 2026
53 checks passed
@konstin
konstin deleted the konsti/pinact-manual branch October 7, 2026 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidhewitt davidhewitt davidhewitt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@konstin @davidhewitt