Visitar URL original
Override `core.filemode=false` in wasm build by ianthomas23 · Pull Request #189 · QuantStack/git2cpp · GitHub
Skip to content

Override core.filemode=false in wasm build #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JohanMabille merged 2 commits into from
Oct 7, 2026
Merged

Override core.filemode=false in wasm build #189

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f8e028f
Override core.filemode=false in wasm build
ianthomas23 Oct 6, 2026
507e2f6
Harden wasm tests
ianthomas23 Oct 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Harden wasm tests
  • Loading branch information
@ianthomas23
ianthomas23 committed Oct 7, 2026
commit 507e2f6b75364eeae54be68804c3df52cfb30914
6 changes: 3 additions & 3 deletions test/conftest_wasm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,11 +170,11 @@ def subprocess_run(
raise RuntimeError(f"Error setting cwd to {cwd}")

def maybe_wrap_arg(s: str | MockPath) -> str:
# An argument containing spaces needs to be wrapped in quotes if it is not already, due
# to how the command is passed to cockle as a single string.
# An argument containing whitespace (including newlines) needs to be wrapped in quotes if
# it is not already, due to how the command is passed to cockle as a single string.
# Could do better here.
s = str(s)
if " " in s and not s.endswith("'"):
if re.search(r"\s", s) and not s.endswith("'"):
return "'" + s + "'"
return s

Expand Down
Loading