Visitar URL original
fix: add the missing translation key for the team converted to channel toast by Kulraj69 · Pull Request #43311 · RocketChat/Rocket.Chat · GitHub
Skip to content

fix: add the missing translation key for the team converted to channel toast - #43311

Open
Kulraj69 wants to merge 1 commit into
RocketChat:developfrom
Kulraj69:fix-43288-team-converted-to-channel-toast
Open

fix: add the missing translation key for the team converted to channel toast#43311
Kulraj69 wants to merge 1 commit into
RocketChat:developfrom
Kulraj69:fix-43288-team-converted-to-channel-toast

Conversation

@Kulraj69

@Kulraj69 Kulraj69 commented Oct 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Proposed changes

The success toast for converting a team to a channel calls t('Team_converted_to_channel'), but that key is missing from en.i18n.json, so the toast displayed the raw key instead of a message. This adds the key to the base locale. Other languages fall back to en and can be translated separately, and the i18n linter keeps the file sorted.

Issue(s)

Fixes #43288

Steps to test or reproduce

  1. Open a team you can edit, then Team Info > "Convert to Channel" and confirm the modal.
  2. Expected: the toast reads "Team has been converted to a channel" instead of Team_converted_to_channel.

I could not run the Meteor app or its unit tests on this machine (the monorepo install does not fit), so step 2 is the expected behaviour from the code, not an observed run. What I did run: node ./src/scripts/check.mts in packages/i18n (the i18n linter enforced in CI) before and after the change - it passes, and the key sits in the position the linter expects.

No automated test is added: the repo has no test for toast strings, and a test for this key alone would only repeat the lookup. Say the word if you want one.

Further comments

No changeset, matching other translation-only PRs (for example #43250): this only adds a base-locale key.

@dionisio-bot

dionisio-bot Bot commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot

changeset-bot Bot commented Oct 29, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: f93fb04

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed Oct 29, 2026
View reviewed changes

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

You’re at about 94% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.

View guided diff | Re-trigger cubic

@coderabbitai

coderabbitai Bot commented Oct 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: ae6f1f69-e464-405a-b53b-2b6020f57b91
Commits

Reviewing files that changed from the base of the PR and between d760352 and f93fb04.

Files selected for processing: 1
  • packages/i18n/src/locales/en.i18n.json

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

Recent review details
Additional context used
Learnings: 1
Common learnings 
Learnt from: d-gubert
Repo: RocketChat/Rocket.Chat PR: 37547
File: packages/i18n/src/locales/en.i18n.json:634-634
Timestamp: 2025-11-19T12:32:29.696Z
Learning: Repo: RocketChat/Rocket.Chat
Context: i18n workflow
Learning: In this repository, new translation keys should be added to packages/i18n/src/locales/en.i18n.json only; other locale files are populated via the external translation pipeline and/or fall back to English. Do not request adding the same key to all locale files in future reviews.
Additional comments: 1
packages/i18n/src/locales/en.i18n.json: 1

6632-6632: LGTM!

Walkthrough

The English locale now defines Team_converted_to_channel as “Team has been converted to a channel”.

Changes

Team conversion translation

Layer / File(s) Summary
Add the English success message
packages/i18n/src/locales/en.i18n.json		 Adds the Team_converted_to_channel key with the text “Team has been converted to a channel”.

Priority: Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix · Severity of issue fixed: Low

Possibly related issues

Possibly related PRs

Suggested reviewers: kevlehman

Merge Risk: Minimal · up to f93fb

The conversion toast now has the intended English text and is ready to merge.

Pre-merge checks: Passed 4
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and specifically describes the main change: adding the missing translation key for the team-to-channel conversion toast.
Linked Issues check Passed Issue #43288 requires the conversion success toast to show “Team has been converted to a channel” instead of the raw key. The PR adds Team_converted_to_channel with that English text to `packages/i1…
Out of Scope Changes check Passed The reported change is limited to one English base-locale key. This change directly supports issue #43288 and introduces no unrelated behavior or files.
Full details: Linked Issues check

Explanation

Issue #43288 requires the conversion success toast to show “Team has been converted to a channel” instead of the raw key. The PR adds Team_converted_to_channel with that English text to packages/i18n/src/locales/en.i18n.json. The issue identifies the existing toast call, so the added base-locale key resolves the missing translation. The supplied PR evidence also reports that the i18n linter passes.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Errors were encountered while retrieving linked issues.

Errors: 1
  • JIRA integration encountered authorization issues. Please disconnect and reconnect the integration in the CodeRabbit UI.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cubic-dev-ai cubic-dev-ai[bot] cubic-dev-ai[bot] left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

community

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Converting a Team to a Channel displays raw string 'Team_converted_to_channel' in toast message.

1 participant

@Kulraj69