Visitar URL original
str.isprintable by yanganto · Pull Request #1024 · RustPython/RustPython · GitHub
Skip to content

str.isprintable - #1024

Merged
coolreader18 merged 1 commit into
RustPython:masterfrom
yanganto:str_isprintable
Jun 9, 2019
Merged

str.isprintable#1024
coolreader18 merged 1 commit into
RustPython:masterfrom
yanganto:str_isprintable

Conversation

@yanganto

@yanganto yanganto commented Jun 9, 2019

Copy link
Copy Markdown
Contributor

Implement isprintable function of str object

@coolreader18 coolreader18 added the C-compat A discrepancy between RustPython and CPython label Jun 9, 2019
@codecov-io

codecov-io commented Jun 9, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1024 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1024      +/-   ##
==========================================
+ Coverage    64.7%   64.71%   +0.01%     
==========================================
  Files          97       97              
  Lines       17041    17047       +6     
  Branches     3799     3800       +1     
==========================================
+ Hits        11026    11032       +6     
  Misses       3441     3441              
  Partials     2574     2574
Impacted Files Coverage Δ
vm/src/obj/objstr.rs 74% <100%> (+0.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b968e9...f76be43. Read the comment docs.

@yanganto yanganto mentioned this pull request Jun 9, 2019
Closed
windelbouwman
windelbouwman reviewed Jun 9, 2019
View reviewed changes
Comment thread vm/src/obj/objstr.rs Outdated
windelbouwman
windelbouwman reviewed Jun 9, 2019
View reviewed changes
Comment thread vm/src/obj/objstr.rs Outdated
@windelbouwman

windelbouwman commented Jun 9, 2019

Copy link
Copy Markdown
Contributor

@yanganto thank you for contributing to this project! I left some review comments in your changes.

@yanganto
yanganto force-pushed the str_isprintable branch 4 times, most recently from 53adcc9 to c8d45a1 Compare June 9, 2019 12:54
coolreader18
coolreader18 approved these changes Jun 9, 2019
View reviewed changes
Comment thread vm/src/obj/objstr.rs
Comment thread vm/src/obj/objstr.rs Outdated
Antonio Yang
str.isprintable
f76be43 
- check unicode type by unicode_categories
- rm redundant check of empty string
@coolreader18 coolreader18 removed the C-compat A discrepancy between RustPython and CPython label Jun 9, 2019
@coolreader18
coolreader18 merged commit 68011df into RustPython:master Jun 9, 2019
@yanganto yanganto mentioned this pull request Jun 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coolreader18 coolreader18 coolreader18 approved these changes
+1 more reviewer
@windelbouwman windelbouwman windelbouwman left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yanganto @codecov-io @windelbouwman @coolreader18