Visitar URL original
Align psuedo ops to CPython 3.14.2 by youknowone · Pull Request #6846 · RustPython/RustPython · GitHub
Skip to content

Align psuedo ops to CPython 3.14.2 #6846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 2 commits into from
Jan 24, 2026
Merged

Align psuedo ops to CPython 3.14.2 #6846

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
771650a
align HAVE_ARGUMENT
youknowone Jan 23, 2026
c0bdb9a
align psuedo ops to 3.14.2
youknowone Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
align HAVE_ARGUMENT
  • Loading branch information
@youknowone
youknowone committed Jan 24, 2026
commit 771650a012f0e277112fbcecd2017a6270567ba0
2 changes: 2 additions & 0 deletions crates/compiler-core/src/bytecode/instruction.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -426,6 +426,8 @@ impl InstructionMetadata for Instruction {
| Self::JumpForward { target: l }
| Self::PopJumpIfTrue { target: l }
| Self::PopJumpIfFalse { target: l }
| Self::PopJumpIfNone { target: l }
| Self::PopJumpIfNotNone { target: l }
| Self::ForIter { target: l }
| Self::Send { target: l } => Some(*l),
_ => None,
Expand Down
4 changes: 2 additions & 2 deletions crates/stdlib/src/_opcode.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@ mod _opcode {
}

impl Opcode {
// https://github.com/python/cpython/blob/bcee1c322115c581da27600f2ae55e5439c027eb/Include/opcode_ids.h#L238
const HAVE_ARGUMENT: i32 = 44;
// https://github.com/python/cpython/blob/v3.14.2/Include/opcode_ids.h#L252
const HAVE_ARGUMENT: i32 = 43;

pub fn try_from_pyint(raw: PyIntRef, vm: &VirtualMachine) -> PyResult<Self> {
let instruction = raw
Expand Down