Visitar URL original
gc: add CollectResult, stats fields, get_referrers, and fix count reset by youknowone · Pull Request #7354 · RustPython/RustPython · GitHub
Skip to content

gc: add CollectResult, stats fields, get_referrers, and fix count reset #7354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 10 commits into from
Mar 12, 2026
+349 −94
Merged

gc: add CollectResult, stats fields, get_referrers, and fix count reset #7354

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
d4d329f
gc: add CollectResult, stats fields, get_referrers, and fix count reset
youknowone Mar 5, 2026
c889a96
Update test_gc from v3.14.3
Mar 5, 2026
a34d701
Update test_gc.py from CPython v3.15.0a5
youknowone Mar 5, 2026
463eb1d
Fix gc_state build on wasm32: skip Instant timing
youknowone Mar 5, 2026
dfee990
Add candidates/duration to gc callback info, mark v3.15 test failures
youknowone Mar 5, 2026
2547ef8
Fix gc.get_referrers to exclude executing frames, fix Future cancelle…
youknowone Mar 6, 2026
980c731
Fix gc.get_threshold to return actual gen2 threshold value
youknowone Mar 9, 2026
f1d0b44
Fix inconsistent GC count reset in early-return paths
youknowone Mar 9, 2026
2282a51
Accept keyword arguments in socket.__init__
youknowone Mar 9, 2026
d62481f
Disable comp_inlined in symbol table to match compiler
youknowone Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Disable comp_inlined in symbol table to match compiler 
The compiler does not yet implement PEP 709 inlined comprehensions
(is_inlined_comprehension_context always returns false), but the
symbol table was marking comprehensions as inlined. This mismatch
could cause comprehension-local symbols to be merged into the parent
scope while the compiler still looks them up in a separate scope.
  • Loading branch information
@youknowone
youknowone committed Mar 10, 2026
commit d62481f552d5eccd1cf60ccdfb5b843541e42eab
1 change: 0 additions & 1 deletion Lib/test/test_symtable.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -561,7 +561,6 @@ def get_identifiers_recursive(self, st, res):
for ch in st.get_children():
self.get_identifiers_recursive(ch, res)

@unittest.expectedFailure # TODO: RUSTPYTHON; AssertionError: 2 != 1
def test_loopvar_in_only_one_scope(self):
# ensure that the loop variable appears only once in the symtable
comps = [
Expand Down
21 changes: 7 additions & 14 deletions crates/codegen/src/symboltable.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2037,20 +2037,13 @@ impl SymbolTableBuilder {
self.line_index_start(range),
);

// Mark non-generator comprehensions as inlined (PEP 709)
// inline_comp = entry->ste_comprehension && !entry->ste_generator && !ste->ste_can_see_class_scope
// We check is_generator and can_see_class_scope of parent
let parent_can_see_class = self
.tables
.get(self.tables.len().saturating_sub(2))
.map(|t| t.can_see_class_scope)
.unwrap_or(false);
if !is_generator
&& !parent_can_see_class
&& let Some(table) = self.tables.last_mut()
{
table.comp_inlined = true;
}
// PEP 709: inlined comprehensions are not yet implemented in the
// compiler (is_inlined_comprehension_context always returns false),
// so do NOT mark comp_inlined here. Setting it would cause the
// symbol-table analyzer to merge comprehension-local symbols into
// the parent scope, while the compiler still emits a separate code
// object — leading to the merged symbols being missing from the
// comprehension's own symbol table lookup.

// Register the passed argument to the generator function as the name ".0"
self.register_name(".0", SymbolUsage::Parameter, range)?;
Expand Down
Loading