Visitar URL original
Bytecode parity CFG normalization and jump cleanup by youknowone · Pull Request #7721 · RustPython/RustPython · GitHub
Skip to content

Bytecode parity CFG normalization and jump cleanup #7721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 7 commits into from
Apr 30, 2026
Merged

Bytecode parity CFG normalization and jump cleanup #7721

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5023570
typealias reviews
youknowone Apr 22, 2026
701b081
Bytecode parity - try/except block order, CFG reorder
youknowone Apr 22, 2026
5565f98
Align CFG cleanup bytecode with CPython
youknowone Apr 28, 2026
b54cfd6
Unmark test_dis.test_findlabels expected failure
youknowone Apr 29, 2026
23c689d
Compute target predecessor flags in single pass
youknowone Apr 29, 2026
238d1e7
Address review feedback on slice folding, fallthrough, attr-chain
youknowone Apr 30, 2026
c267535
remove test
youknowone Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .cspell.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@
"jitted",
"jitting",
"kwonly",
"lolcatz",

@youknowone youknowone Apr 30, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding vocabulary only for string in test data is bad idea

@fanninpm fanninpm Apr 30, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe leave it as a single ignore statement in one file?

@youknowone youknowone Apr 30, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test was duplication of test_dis.py. removed the test

"lossily",
"mcache",
"oparg",
Expand Down
1 change: 0 additions & 1 deletion Lib/test/test_dis.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2410,7 +2410,6 @@ def test__find_store_names(self):
res = tuple(dis._find_store_names(code))
self.assertEqual(res, expected)

@unittest.expectedFailure # TODO: RUSTPYTHON
def test_findlabels(self):
labels = dis.findlabels(jumpy.__code__.co_code)
jumps = [
Expand Down
Loading
Loading