Add CFF2 and TrueType Variation Font Support - #342

Codecov Report

❌ Patch coverage is 80.13732% with 405 lines in your changes missing coverage. Please review.
✅ Project coverage is 83%. Comparing base (1ac46b2) to head (59b5173).
⚠️ Report is 74 commits behind head on main.

@@           Coverage Diff           @@
##            main    #342     +/-   ##
=======================================
- Coverage     83%     83%     -1%     
=======================================
  Files        274     302     +28     
  Lines      19169   20884   +1715     
  Branches    2714    3026    +312     
=======================================
+ Hits       16049   17462   +1413     
- Misses      2442    2658    +216     
- Partials     678     764     +86     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brianpopow I had a quick look at the ItemVariationData and spotted an issue with the longwords check however I'm not sure how you tested the values here. How did you compare the values?

@brianpopow I had a quick look at the ItemVariationData and spotted an issue with the longwords check however I'm not sure how you tested the values here. How did you compare the values?

I use the tagged version 1.8.0 of fontkit and the CFF2 font RobotoFlex.ttf linked above.
To debug fontkit, I use a unit test. As IDE, I do use webstorm. For example create a new file example.js in test folder of fontkit with the following code:

import fontkit from '../src';
import assert from 'assert';
import fs from 'fs';

describe('metadata', function() {
    it('fontkit test', function() {
        let font = fontkit.openSync(__dirname + '/data/RobotoFlex.ttf');
        var variationFont = font.getVariation({wght: 300})
        var run = font.layout("hello");
    });
});

This creates a new font variation with the weight 300 as an option. Then add a breakpoint, when the font is loaded and inspect font or variationFont. Look into the HVAR table and then into itemVariationStore -> itemVariationData.
For easier reading I usually do right click and Copy Json and past into into a text file.

This all seems to work now. Fantastic!

@JimBobSquarePants : great to see, that you managed to finish this!

This all seems to work now. Fantastic!

@JimBobSquarePants : great to see, that you managed to finish this!

Only with your help mate!!! 🤩