Visitar URL original
APNG support by Poker-sang · Pull Request #2511 · SixLabors/ImageSharp · GitHub
Skip to content

APNG support - #2511

Merged
JimBobSquarePants merged 25 commits into
SixLabors:mainfrom
Poker-sang:main
Oct 31, 2023
Merged

APNG support#2511
JimBobSquarePants merged 25 commits into
SixLabors:mainfrom
Poker-sang:main

Conversation

@Poker-sang

@Poker-sang Poker-sang commented Aug 12, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Implement APNG decoding and encoding based on PNG

@CLAassistant

CLAassistant commented Aug 12, 2023 •
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@Poker-sang
Poker-sang marked this pull request as draft August 12, 2023 10:34
@Poker-sang
Poker-sang marked this pull request as ready for review August 12, 2023 14:45
JimBobSquarePants
JimBobSquarePants requested changes Aug 17, 2023
View reviewed changes

@JimBobSquarePants JimBobSquarePants left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, I really appreciate your efforts!

I've tried to offer guidance as to what need to change. Please let me know if anything doesn't make sense.

Comment thread src/ImageSharp/Configuration.cs Resolved
Comment thread src/ImageSharp/Formats/Png/APngBlendOperation.cs Resolved
Comment thread src/ImageSharp/Formats/Png/APngDisposeOperation.cs Resolved
Comment thread src/ImageSharp/Formats/Png/APngFrameMetadata.cs Resolved
Comment thread src/ImageSharp/Formats/Png/Chunks/APngAnimationControl.cs Resolved
Comment thread src/ImageSharp/Formats/Png/PngDecoderCore.cs Resolved
Comment thread src/ImageSharp/Formats/Png/PngDecoderCore.cs Resolved
Comment thread src/ImageSharp/Formats/Png/PngDecoderCore.cs Resolved
Comment thread src/ImageSharp/Formats/Png/PngDecoderCore.cs Resolved
Comment thread src/ImageSharp/ImageSharp.csproj Resolved
@Poker-sang

Poker-sang commented Aug 17, 2023

Copy link
Copy Markdown
Contributor Author

Thanks for your review! It is rigorous and easy for me to understand. I'm sorry for accidentally formatting some code that confused you (e.g. x++ to ++x). Now it's all reverted.

JimBobSquarePants
JimBobSquarePants reviewed Aug 18, 2023
View reviewed changes
Comment thread src/ImageSharp/Formats/Png/PngScanlineProcessor.cs Resolved
JimBobSquarePants
JimBobSquarePants reviewed Aug 18, 2023
View reviewed changes
Comment thread src/ImageSharp/Formats/Png/PngDecoderCore.cs Resolved
antonfirsov
antonfirsov reviewed Aug 19, 2023
View reviewed changes
Comment thread src/ImageSharp/Formats/Png/PngEncoder.cs Resolved
Comment thread src/ImageSharp/Formats/Png/PngEncoderCore.cs Resolved
@JimBobSquarePants

JimBobSquarePants commented Sep 12, 2023

Copy link
Copy Markdown
Member

@Poker-sang Sorry this is taking so long to merge. There's a bit of a backlog we need to shift first to ensure there are no functional conflicts.

@Poker-sang

Poker-sang commented Sep 12, 2023

Copy link
Copy Markdown
Contributor Author

It's all right. Take your time please.

@JimBobSquarePants

JimBobSquarePants commented Oct 3, 2023

Copy link
Copy Markdown
Member

@Poker-sang Thanks again for your patience. Following the merge of #2485 there's a few conflicts here. Would you be able to update your PR to include the updates from main? If not, I can have a try.

@Poker-sang

Poker-sang commented Oct 4, 2023

Copy link
Copy Markdown
Contributor Author

I can have a try. But I'm sorry I can't handle it for I'm busy these days. If you're not in a hurry you can wait a few days for me. ☺️ Or you can handle it the way you want if it doesn't bother you.

@JimBobSquarePants

JimBobSquarePants commented Oct 17, 2023

Copy link
Copy Markdown
Member

I'm having a go at merging main back into this PR now.

This was referenced Oct 30, 2026
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Closed
Open
Open
Open
Open
Merged
Open
Open
Closed
Open
Open
Open
Closed
@dependabot dependabot Bot mentioned this pull request Nov 8, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonfirsov antonfirsov antonfirsov left review comments
@JimBobSquarePants JimBobSquarePants JimBobSquarePants approved these changes

Assignees

No one assigned

Labels

enhancement formats:png

Projects

None yet

Milestone

v3.1.0

Development

Successfully merging this pull request may close these issues.

4 participants

@Poker-sang @CLAassistant @JimBobSquarePants @antonfirsov