Visitar URL original
Update to net8 by stefannikolei · Pull Request #2583 · SixLabors/ImageSharp · GitHub
Skip to content

Update to net8 - #2583

Merged
JimBobSquarePants merged 20 commits into
SixLabors:mainfrom
stefannikolei:sn/net8
Dec 4, 2023
Merged

Update to net8#2583
JimBobSquarePants merged 20 commits into
SixLabors:mainfrom
stefannikolei:sn/net8

Conversation

@stefannikolei

@stefannikolei stefannikolei commented Nov 18, 2023

Copy link
Copy Markdown
Contributor

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

@stefannikolei
stefannikolei marked this pull request as ready for review November 19, 2023 10:11
stefannikolei
stefannikolei commented Nov 19, 2023
View reviewed changes
Comment thread src/ImageSharp.ruleset Resolved
Comment thread src/ImageSharp.ruleset Outdated
<Include Path="..\shared-infrastructure\sixlabors.ruleset" Action="Default" />
<Rules AnalyzerId="Microsoft.CodeAnalysis.CSharp.NetAnalyzers" RuleNamespace="Microsoft.CodeAnalysis.CSharp.NetAnalyzers">
<Rule Id="CA1857" Action="None" />
<Rule Id="CA1859" Action="None" />

@stefannikolei stefannikolei Nov 19, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://learn.microsoft.com/de-de/dotnet/fundamentals/code-analysis/quality-rules/ca1859

I disabled this to get a build without errors. I can remove it and fix all places

@JimBobSquarePants JimBobSquarePants Dec 3, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should open up a discussion or issue to track it so it's not forgotten.

@JimBobSquarePants JimBobSquarePants Dec 4, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just had a hack at this. Only 3 changes required in private methods.

Comment thread src/ImageSharp/Formats/ImageFormatManager.cs Resolved
@JimBobSquarePants

JimBobSquarePants commented Nov 20, 2023

Copy link
Copy Markdown
Member

Thanks for this. You might want to put a pause on it though until we ship v3.1 We'll need to update SharedInfrastructure submodule following that.

@stefannikolei

stefannikolei commented Nov 29, 2023

Copy link
Copy Markdown
Contributor Author

@JimBobSquarePants should we run the arm tests before we merge this?

@JimBobSquarePants JimBobSquarePants added enhancement breaking Signifies a binary breaking change. arch:arm64 labels Nov 29, 2023
@JimBobSquarePants

JimBobSquarePants commented Nov 29, 2023

Copy link
Copy Markdown
Member

@stefannikolei triggered.

stefannikolei
stefannikolei commented Dec 1, 2023
View reviewed changes
Comment thread src/ImageSharp/ImageSharp.csproj Resolved
JimBobSquarePants
JimBobSquarePants reviewed Dec 1, 2023
View reviewed changes
Comment thread src/ImageSharp/Memory/Allocators/Internals/SharedArrayPoolBuffer{T}.cs Resolved
Comment thread src/ImageSharp/Common/Helpers/Numerics.cs Resolved
This was referenced Oct 27, 2026
Closed
Open
Open
Closed
Closed
Closed
Open
Open
Closed
Open
Closed
Open
Open
Open
This was referenced Nov 3, 2026
Closed
Open
Open
Closed
Open
Open
Closed
Open
Closed
Open
This was referenced Nov 11, 2026
Merged
Merged
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JimBobSquarePants JimBobSquarePants JimBobSquarePants approved these changes

Assignees

No one assigned

Labels

arch:arm64 breaking Signifies a binary breaking change. enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@stefannikolei @JimBobSquarePants