Repository navigation
Fix noise level cache invalidation and sampling parameters - #4942
Open
emanueldellipaoli01-a11y wants to merge 2 commits into
Open
emanueldellipaoli01-a11y wants to merge 2 commits into
emanueldellipaoli01-a11y wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #4928 by improving how noise levels are cached and reused.
The main idea is to keep track of the sampling parameters used to compute each noise-level estimate, so that cached values are only reused when they are compatible with the current request.
In particular, this PR:
chunk_durationto frames.recording._noise_levels_params.seed=Noneis requested, an existing estimate can be reused regardless of the stored seed, as long as the chunk layout is compatible.gain_to_uVoroffset_to_uVchange.highpass_spatial_filterto obtain RMS values throughget_noise_levels()instead of accessing the cached property directly.Regression tests have been added for the caching behavior, parameter compatibility, seed handling, calibration changes, and the high-pass spatial filter integration.