Visitar URL original
refactor(settings)!: rebuild the theme engine on a slot registry by datlechin · Pull Request #2791 · TableProApp/TablePro · GitHub
Skip to content

refactor(settings)!: rebuild the theme engine on a slot registry - #2791

Open
datlechin wants to merge 12 commits into
mainfrom
theme/1-engine-v2
Open

datlechin wants to merge 12 commits into
mainfrom
theme/1-engine-v2

Conversation

@datlechin

@datlechin datlechin commented Sep 12, 2026 •

Copy link
Copy Markdown
Member

Why

Theme color groups shipped editable and read by nothing (Interface, Sidebar, Toolbar), and a malformed theme file loaded silently as Default Light. #2775 and #2781 fixed both, were taken back out by #2790 for review, and a later merge of main into this branch had dropped the engine again.

Change

Verified

Build, SwiftLint and the catalog check pass; 1,975 of 1,981 cases in the suites owning the changed types and the guard suites passed in one batch; 5 of the failures are load-timing and pass alone, the sixth was the separator color, fixed

Two tests follow the engine: the confusable-character underline is the theme's warning color, and the Vim UI suite scrolls to the Vim mode toggle, which the Editor Font section pushes below the fold of the default Settings window (scrollUntilHittable in UITestCase). The UI suite could not run locally, so CI is its first run. here. New tests cover the tree outline recoloring on a theme change and the grid line reaching the separators.

Not in this PR

@mintlify

mintlify Bot commented Sep 15, 2026 •

Copy link
Copy Markdown

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated
TablePro 🟢 Ready View Preview Sep 17, 2026, 10:43 PM

💡 Tip: Enable Automations to automatically generate PRs for you.

# Conflicts:
#	docs/customization/appearance.mdx
# Conflicts:
#	docs/customization/appearance.mdx
@datlechin datlechin changed the title refactor(settings)!: rebuild the theme engine on a slot registry with a schema gate refactor(settings)!: rebuild the theme engine on a slot registry Oct 11, 2026

This branch was successfully deployed

1 active (outdated) deployment
staging - docs — 282a7117 Deployed Sep 17, 2026 by mintlify[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant