Repository navigation
Conversation
… a schema gate (#2775) Signed-off-by: Ngô Quốc Đạt <datlechin@gmail.com>
This was referenced Sep 12, 2026
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Automations to automatically generate PRs for you. |
# Conflicts: # docs/customization/appearance.mdx
datlechin
added this pull request to stack #3111
September 24, 2026 10:54
# Conflicts: # docs/customization/appearance.mdx
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Theme color groups shipped editable and read by nothing (Interface, Sidebar, Toolbar), and a malformed theme file loaded silently as Default Light. #2775 and #2781 fixed both, were taken back out by #2790 for review, and a later merge of
maininto this branch had dropped the engine again.Change
main:ThemeSlotregistry,ThemeCatalog,ThemeResolver, schema 2 theme files with Not Loaded reasons, fonts moved to Settings > Editor and Data.ObservableObjectinstead of Observation, with every view that reads the palette observing the engine.Verified
Build, SwiftLint and the catalog check pass; 1,975 of 1,981 cases in the suites owning the changed types and the guard suites passed in one batch; 5 of the failures are load-timing and pass alone, the sixth was the separator color, fixed
Two tests follow the engine: the confusable-character underline is the theme's warning color, and the Vim UI suite scrolls to the Vim mode toggle, which the Editor Font section pushes below the fold of the default Settings window (
scrollUntilHittableinUITestCase). The UI suite could not run locally, so CI is its first run. here. New tests cover the tree outline recoloring on a theme change and the grid line reaching the separators.Not in this PR