Visitar URL original
feat(ui5-message-strip): introduce custom colors by niyap · Pull Request #8757 · UI5/webcomponents · GitHub
Skip to content

feat(ui5-message-strip): introduce custom colors - #8757

Merged
niyap merged 5 commits into
mainfrom
msgstripcustomcolors
Apr 16, 2024
Merged

feat(ui5-message-strip): introduce custom colors#8757
niyap merged 5 commits into
mainfrom
msgstripcustomcolors

Conversation

@niyap

@niyap niyap commented Apr 15, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

With the following enhancement, the end user will be able to create message strips with custom colors from a predefined set of colors. That is achieved enhancing the design property enum MessageStripDesign with two new options ColorSet1 and ColorSet2 as well as the newly introduced property colorScheme.
Setting the design property value to ColorSet1 or ColorSet2, then you are able to choose between 10 different colors for each using colorScheme property with values from "1" to "10".

@niyap
niyap requested a review from elenastoyanovaa April 15, 2024 08:44
elenastoyanovaa
elenastoyanovaa requested changes Apr 15, 2024
View reviewed changes

@elenastoyanovaa elenastoyanovaa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Add a sample to the new playground

Comment thread packages/main/src/MessageStrip.ts Resolved
Comment thread packages/main/src/themes/base/MessageStrip-parameters.css Resolved
Comment thread packages/main/src/themes/sap_fiori_3/MessageStrip-parameters.css Resolved
Comment thread packages/main/src/themes/sap_fiori_3_dark/MessageStrip-parameters.css Resolved
Comment thread packages/main/src/themes/sap_horizon_dark/MessageStrip-parameters.css Resolved
Comment thread packages/main/src/types/MessageStripDesign.ts Resolved
Comment thread packages/main/test/pages/MessageStrip.html Resolved
elenastoyanovaa
elenastoyanovaa reviewed Apr 15, 2024
View reviewed changes

@elenastoyanovaa elenastoyanovaa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding the commit message - maybe custom messages is not the best description. The customisation is actually only visual. Maybe something like

With the following enhancement, the end user will be able to message strips with custom colors, from a predefined set of colors.

elenastoyanovaa
elenastoyanovaa requested changes Apr 15, 2024
View reviewed changes
Comment thread packages/main/src/MessageStrip.ts Resolved
@niyap niyap changed the title feat(ui5-message-strip): introduce custom messages feat(ui5-message-strip): introduce custom colors Apr 15, 2024
@niyap

niyap commented Apr 16, 2024

Copy link
Copy Markdown
Contributor Author

Regarding the commit message - maybe custom messages is not the best description. The customisation is actually only visual. Maybe something like

With the following enhancement, the end user will be able to message strips with custom colors, from a predefined set of colors.

Done

elenastoyanovaa
elenastoyanovaa requested changes Apr 16, 2024
View reviewed changes
Comment thread packages/main/src/MessageStrip.ts Resolved
@niyap niyap added 2.0 enhancement New feature or request labels Apr 16, 2024
@niyap
niyap merged commit d30f424 into main Apr 16, 2024
@niyap
niyap deleted the msgstripcustomcolors branch April 16, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@elenastoyanovaa elenastoyanovaa elenastoyanovaa approved these changes
@simonarangelova simonarangelova simonarangelova approved these changes

Assignees

No one assigned

Labels

2.0 enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@niyap @elenastoyanovaa @simonarangelova