Repository navigation
Move Cocoa-only IPC tests to ipc/cocoa and http/tests/ipc/cocoa - #76314
Merged
webkit-commit-queue merged 1 commit intoOct 9, 2026
Merged
Conversation
csaavedra
added
the
Tools / Tests
Collaborator
|
EWS run on previous version of this PR (hash fa9bc9b) Details |
achristensen07
approved these changes
Oct 8, 2026
csaavedra
force-pushed
the
eng/move-cocoa-only-ipc-tests
branch
from
October 9, 2026 03:53
fa9bc9b to
ab1ed60
Compare
Collaborator
|
EWS run on current version of this PR (hash ab1ed60) Details |
csaavedra
added
the
unsafe-merge-queue
webkit-commit-queue
force-pushed
the
eng/move-cocoa-only-ipc-tests
branch
from
October 9, 2026 09:37
ab1ed60 to
02d59a3
Compare
https://bugs.webkit.org/show_bug.cgi?id=326811 Reviewed by Alex Christensen. These tests exercise Cocoa-only receivers or payloads (PrepareImageBufferSetsForDisplay, AVFoundation media engines, AVContentKeySession, CoreText font palettes, NSError), so non-Cocoa ports had to skip them one by one. Move them under the existing ipc/cocoa directory gating, and add the same gating for a new http/tests/ipc/cocoa directory. remotedisplaylistrecorder-drawcontrolpart-slidertrackpart-crash.html moves along with executor.js, its only user, which needs PrepareImageBufferSetsForDisplay to create the graphics context. nested-display-list-draw-control-part-crash.html already covers DrawControlPart decoding on the other ports. The [ Debug ] entries for gpu-load-error-empty-user-info-crssh.html and media-containment-bypass-create-player.html move from TestExpectations and platform/wk2 to the Cocoa platform files, since the directory [ Pass ] lines there would otherwise override them. * LayoutTests/TestExpectations: * LayoutTests/http/tests/ipc/cocoa/gpu-load-error-empty-user-info-crssh-expected.txt: Renamed from LayoutTests/http/tests/ipc/gpu-load-error-empty-user-info-crssh-expected.txt. * LayoutTests/http/tests/ipc/cocoa/gpu-load-error-empty-user-info-crssh.html: Renamed from LayoutTests/http/tests/ipc/gpu-load-error-empty-user-info-crssh.html. * LayoutTests/http/tests/ipc/cocoa/webpageproxy-didfailload-failingurl-message-check-expected.txt: Renamed from LayoutTests/http/tests/ipc/webpageproxy-didfailload-failingurl-message-check-expected.txt. * LayoutTests/http/tests/ipc/cocoa/webpageproxy-didfailload-failingurl-message-check.html: Renamed from LayoutTests/http/tests/ipc/webpageproxy-didfailload-failingurl-message-check.html. * LayoutTests/ipc/cocoa/cache-font-null-palette-colors-crash-expected.txt: Renamed from LayoutTests/ipc/cache-font-null-palette-colors-crash-expected.txt. * LayoutTests/ipc/cocoa/cache-font-null-palette-colors-crash.html: Renamed from LayoutTests/ipc/cache-font-null-palette-colors-crash.html. * LayoutTests/ipc/cocoa/executor.js: Renamed from LayoutTests/ipc/executor.js. * LayoutTests/ipc/cocoa/legacy-cdm-session-avcontentkeysession-destruction-race-expected.txt: Renamed from LayoutTests/ipc/legacy-cdm-session-avcontentkeysession-destruction-race-expected.txt. * LayoutTests/ipc/cocoa/legacy-cdm-session-avcontentkeysession-destruction-race.html: Renamed from LayoutTests/ipc/legacy-cdm-session-avcontentkeysession-destruction-race.html. * LayoutTests/ipc/cocoa/mark-surfaces-volatile-during-prepare-for-display-expected.txt: Renamed from LayoutTests/ipc/mark-surfaces-volatile-during-prepare-for-display-expected.txt. * LayoutTests/ipc/cocoa/mark-surfaces-volatile-during-prepare-for-display.html: Renamed from LayoutTests/ipc/mark-surfaces-volatile-during-prepare-for-display.html. * LayoutTests/ipc/cocoa/media-containment-bypass-create-player-expected.txt: Renamed from LayoutTests/ipc/media-containment-bypass-create-player-expected.txt. * LayoutTests/ipc/cocoa/media-containment-bypass-create-player.html: Renamed from LayoutTests/ipc/media-containment-bypass-create-player.html. * LayoutTests/ipc/cocoa/remotedisplaylistrecorder-drawcontrolpart-slidertrackpart-crash-expected.txt: Renamed from LayoutTests/ipc/remotedisplaylistrecorder-drawcontrolpart-slidertrackpart-crash-expected.txt. * LayoutTests/ipc/cocoa/remotedisplaylistrecorder-drawcontrolpart-slidertrackpart-crash.html: Renamed from LayoutTests/ipc/remotedisplaylistrecorder-drawcontrolpart-slidertrackpart-crash.html. * LayoutTests/platform/glib/TestExpectations: * LayoutTests/platform/ios-simulator/TestExpectations: * LayoutTests/platform/ios/TestExpectations: * LayoutTests/platform/mac-wk2/TestExpectations: * LayoutTests/platform/visionos/TestExpectations: * LayoutTests/platform/wk2/TestExpectations: Canonical link: https://commits.webkit.org/323208@main
webkit-commit-queue
force-pushed
the
eng/move-cocoa-only-ipc-tests
branch
from
October 9, 2026 09:38
02d59a3 to
a92f48e
Compare
Collaborator
|
Committed 323208@main (a92f48e): https://commits.webkit.org/323208@main Reviewed commits have been landed. Closing PR #76314 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a92f48e
ab1ed60
🛠 win🧪 win-tests🧪 api-mac-debug🧪 api-ios🧪 mac-AS-debug-wk2🧪 mac-intel-wk2