Visitar URL original
Add unit tests for exception handling by Beeram12 · Pull Request #151 · XortexAI/XMem · GitHub
Skip to content
This repository was archived by the owner on Jun 3, 2026. It is now read-only.

Add unit tests for exception handling - #151

Draft
Beeram12 wants to merge 2 commits into
XortexAI:mainfrom
Beeram12:feature/unit-tests
Draft

Add unit tests for exception handling#151
Beeram12 wants to merge 2 commits into
XortexAI:mainfrom
Beeram12:feature/unit-tests

Conversation

@Beeram12

@Beeram12 Beeram12 commented May 5, 2026 •
edited
Loading

Copy link
Copy Markdown

fixes #147

  1. This adds unit tests for exception.py .

@github-actions github-actions Bot added the tests label May 5, 2026
gemini-code-assist[bot]
gemini-code-assist Bot reviewed May 5, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request unignores the tests/ directory and introduces a new test suite for the project's custom exception hierarchy. The feedback focuses on improving test accuracy by fixing a typo and directly verifying attributes, adhering to PEP 8 standards for None comparisons, and ensuring complete coverage of the exception hierarchy by adding a test for VectorStoreValidationError.

Comment thread tests/test_exception.py Resolved
Comment thread tests/test_exception.py Resolved
Comment thread tests/test_exception.py Resolved
@ishaanxgupta

ishaanxgupta commented May 8, 2026

Copy link
Copy Markdown
Contributor

@Beeram12 Please have a look on the gemini suggestions

@Beeram12

Beeram12 commented May 8, 2026

Copy link
Copy Markdown
Author

@Beeram12 Please have a look on the gemini suggestions

yeah I have resovled all but I didnt commit

This branch has not been deployed

No deployments
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ishaanxgupta ishaanxgupta Awaiting requested review from ishaanxgupta ishaanxgupta will be requested when the pull request is marked ready for review ishaanxgupta is a code owner
@ved015 ved015 Awaiting requested review from ved015 ved015 will be requested when the pull request is marked ready for review ved015 is a code owner
1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Phase 1: Foundation and Core Unit Tests

2 participants

@Beeram12 @ishaanxgupta