Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR brings the "Rust - Cargo" example inline with the Cargo book.
Supersedes #1167.
Description
This PR adds entries for files
.crates.tomland.crates2.jsonto the existing four directories:Motivation and Context
Not having those files cached can cause spurious errors. For example, suppose one has
cargo-expand@1.0.125installed and one tries to installcargo-expand@1.0.126with the commandcargo install cargo-expand. With the files cached, the installation completes successfully. Without it, one could see an error like this:How Has This Been Tested?
Here are two workflows demonstrating the above claims:
.crates.tomland.crates2.json(cargo install cargo-expandfails).crates.tomland.crates2.json(cargo install cargo-expandsucceeds)For reference, here is a comparison of the two branches on which the workflows were run: smoelius/cache-experiment@main...with-crates-toml-crates2-json
Screenshots (if appropriate):
Types of changes
Checklist: