Visitar URL original
Ensure newline after registry string in npmrc by laat · Pull Request #1503 · actions/setup-node · GitHub
Skip to content

Ensure newline after registry string in npmrc - #1503

Open
laat wants to merge 1 commit into
actions:mainfrom
laat:patch-1
Open

Ensure newline after registry string in npmrc#1503
laat wants to merge 1 commit into
actions:mainfrom
laat:patch-1

Conversation

@laat

@laat laat commented Mar 4, 2026 •
edited
Loading

Copy link
Copy Markdown

Add a newline at the end of the registry string in authutil, to ensure that it's a proper POSIX text file.

Description:

Had to add the newline myself, when adding more registries to npmrc.

    - name: Use Node.js 24.14.x
      uses: actions/setup-node@v6
      with:
        node-version: 24.14.x
        cache: 'pnpm'
        registry-url: 'https://registry.npmjs.org'
        
    - name: 'add bigcorp repo to .npmrc'
      run: |
        echo "" >> ${NPM_CONFIG_USERCONFIG} # <---- workaround for this bug
        echo "//npm.bigcorp.org/:_authToken=${NPM_TOKEN}" >> ${NPM_CONFIG_USERCONFIG}
        echo "@bigcorp:registry=https://npm.bigcorp.org/" >> ${NPM_CONFIG_USERCONFIG}
      shell: bash
      env:
        NPM_TOKEN: ${{ inputs.BIG_CORP_TOKEN }}

Related issue:
Add link to the related issue.

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@laat
laat requested a review from a team as a code owner March 4, 2026 22:29
Copilot AI review requested due to automatic review settings March 4, 2026 22:29
Copilot AI reviewed Mar 4, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes .npmrc formatting produced by configAuthentication by ensuring the generated registry entry ends with a newline, making it easier to append additional registries reliably.

Changes:

  • Append a trailing os.EOL after the registry line when writing .npmrc.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Comment thread src/authutil.ts Outdated
Comment thread src/authutil.ts
@laat
Ensure newline after registry string in authutil
751e407 
Add a newline at the end of the registry string in authutil, to ensure that it's a proper POSIX file.
@laat
laat requested a review from Copilot March 4, 2026 22:41
Copilot AI reviewed Mar 4, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@laat @v-HarithaVattikuti