Repository navigation
ate-env: fail on unknown commands and reject reserved environment ids - #126
Open
KR Ravindra (KR-Ravindra) wants to merge 1 commit into
Open
KR Ravindra (KR-Ravindra) wants to merge 1 commit into
KR Ravindra (KR-Ravindra) wants to merge 1 commit into
Conversation
Signed-off-by: KR Ravindra <42912207+KR-Ravindra@users.noreply.github.com>
KR Ravindra (KR-Ravindra)
marked this pull request as ready for review
November 12, 2026 18:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ate-env list(or any word that is not a built-in) is registered as an environment command. With no subcommand after it, Cobra printsManage environment listhelp and exits 0, so typos look like success in scripts.ate-env create deleteis accepted, but that environment can never be addressed because the built-in wins at dispatch.Part of #117 (the CLI side). Global flags before
<id>are not changed here; that needs--api/--atespacemoved to the root command.Fix
The per-environment command now fails with
unknown command "list"; to address environment "list", follow it with read, write or shell(exit 1), and an unknown subcommand after an id is reported as such. The check runs inArgs, before the client is created.createrejects ids that match a built-in command (create,delete,suspend,manifest,help,completion) before dialing.How tested
TestUnknownCommandFailsandTestCreateRejectsReservedIDsfail on main and pass with the change;go test ./cmd/ate-env,go vet,make verify-gofmt verify-boilerplateclean.Experimented and verified with an AI agent.