Visitar URL original
Apply custom lint all over modules by Jaehwa-Noh · Pull Request #2106 · android/nowinandroid · GitHub
Skip to content

Apply custom lint all over modules - #2106

Open
Jaehwa-Noh wants to merge 9 commits into
android:mainfrom
Jaehwa-Noh:lint-check
Open

Apply custom lint all over modules#2106
Jaehwa-Noh wants to merge 9 commits into
android:mainfrom
Jaehwa-Noh:lint-check

Conversation

@Jaehwa-Noh

@Jaehwa-Noh Jaehwa-Noh commented May 8, 2026

Copy link
Copy Markdown
Contributor

What I have done and why

Custom lint is published under designsystem module and it checks with its dependencies.
But it makes some module missing the lint check.

  • Create dedicated module for lint
  • Apply lint all over the module

Before
image

After
image

Jaehwa-Noh added 6 commits May 8, 2026 21:22
@Jaehwa-Noh
Create lint:impl module.
7912c71 
Change-Id: Ib26ae618bd132c438a4da2b72069a31469885587
@Jaehwa-Noh
Apply lint dedicated module.
281ef87 
Change-Id: I654a8663af53819d08cd3d7d82c839536904b1bb
@Jaehwa-Noh
Update comment.
7b53501 
Change-Id: I49b7e267ef15a3472c16f038769bdeb462da7381
@Jaehwa-Noh
Update README.md
496a6bf 
Change-Id: I7d04a94a416d9b15226cdb3b83713a0d23c96bf2
@Jaehwa-Noh
Set lint on convention.
df7f115 
Change-Id: I16de64865967524b3a0edb0fb1344d44ddbab3c1
@Jaehwa-Noh
Update README
d55dc42 
Change-Id: I4b628b47fd20ad148cb5cd1f0ee9a178ea7473d0
@Jaehwa-Noh
Jaehwa-Noh requested a review from dturner as a code owner May 8, 2026 13:59
gemini-code-assist[bot]
gemini-code-assist Bot reviewed May 8, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request restructures the linting module by moving rule implementations to a new :lint:impl subproject and updating module dependencies and documentation. The review feedback identifies that custom lint rules should be integrated using the lintChecks configuration rather than implementation to avoid unnecessary runtime overhead. Additionally, a package name inconsistency in the test suite needs to be corrected.

Comment thread build-logic/convention/src/main/kotlin/AndroidApplicationConventionPlugin.kt Outdated
Comment thread build-logic/convention/src/main/kotlin/AndroidLibraryConventionPlugin.kt Outdated
Comment thread ...in/com/google/samples/apps/nowinandroid/lint/impl/designsystem/TestMethodNameDetectorTest.kt
@Jaehwa-Noh
change check to path.
b8d0bf7 
Change-Id: I5795fca2eeb2b1e9a82f4c6b1264de6a1c188c86
Jaehwa-Noh added 2 commits May 9, 2026 10:22
@Jaehwa-Noh
Change to compileOnly.
9d5622a 
Change-Id: I90bdaf34b73c6769ca6faf25ac753feabc5ee909
@Jaehwa-Noh
Update documentation.
76b8a29 
Change-Id: Ic6b3265102e4012861eaad7901d84ac50a155a30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dturner dturner Awaiting requested review from dturner dturner is a code owner
1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Jaehwa-Noh